Subtract fee from amount (rebase)#5831
Conversation
src/qt/coincontroldialog.cpp
Outdated
There was a problem hiding this comment.
this code-block needs to be moved one line above as the variable nBytes is used there
|
nit: the second passage of the commit-message is now wrong, this was only true for the initial version of this pull-request, I'd say remove it, to avoid someone gets confused by it. |
|
With regard to future extensibility, I like the idea of adding a JSON structure to sendmany. Should have been done that in the first place instead of the long-winded positional command lines for some methods. |
src/rpcwallet.cpp
Outdated
There was a problem hiding this comment.
Do we really want to extend deprecated methods?
laanwj
force-pushed
the
2015_02_cozz_subtractfee
branch
3 times, most recently
from
a7cd8c2 to
d18e3d2
Compare
|
Agreed. JSON structures as parameter (or as optional parameter) would be more convenient and extendable. |
|
eh, who is deprecating sendmany? If we were to keep one send* method, that would be the one. It is the most general send method. |
|
@laanwj The JSON structure in the current PR only allows for a boolean for each recipient. Are you suggesting it be changed to a parameter object (eg, like getblocktemplate)? If so, I agree that seems like a better approach. As far as multiple recipients sharing the fee, it seems more logical to be using an Array than an Object with only values of "true". |
|
Re-ACK (including @luke-jr commits) |
|
help-description of sendmany is now wrong after switching from object to array |
|
@cozz What's wrong about it? Looks fine to me? |
|
Fixes bitcoin#2724 and bitcoin#1570. Adds the automatically-subtract-the-fee-from-the-amount-and-send-whats-left feature to the GUI and RPC (sendtoaddress,sendmany).
…from, rather than an Object with all values being identical
laanwj
force-pushed
the
2015_02_cozz_subtractfee
branch
from
0978665 to
1d9b378
Compare
|
I've squashed the two squashme commits, as well as @luke-jr's commit that reverts the changes to |
|
Retested ACK.
|
|
Thanks for testing @jonasschnelli |
1d9b378 qa/rpc-tests/wallet: Tests for sendmany (Luke Dashjr) 40a7573 rpcwallet/sendmany: Just take an array of addresses to subtract fees from, rather than an Object with all values being identical (Luke Dashjr) 292623a Subtract fee from amount (Cozz Lovan) 90a43c1 [Qt] Code-movement-only: Format confirmation message in sendcoinsdialog (Cozz Lovan)
4 participants
Rebase #4331