[Refactor] decouple wallet rpc commands#5934
Closed
jonasschnelli wants to merge 5 commits intobitcoin:masterfrom
Closed
[Refactor] decouple wallet rpc commands#5934jonasschnelli wants to merge 5 commits intobitcoin:masterfrom
jonasschnelli wants to merge 5 commits intobitcoin:masterfrom
Conversation
jonasschnelli
force-pushed
the
2015/03/wallet_rpc_flex
branch
from
674fc82 to
07c3027
Compare
Contributor
Author
|
I think this PR's implementation is not perfect and is not very modular. But it would give the opportunity to slowly decouple the wallet from the rest of the core. Longterm goals to achieve with this PR:
|
src/rpcclient.h
Outdated
jonasschnelli
force-pushed
the
2015/03/wallet_rpc_flex
branch
from
07c3027 to
d41f25a
Compare
Contributor
Author
|
Rebased |
Contributor
|
Needs rebase |
Contributor
Author
- this will allow a upcomming modularization of the wallet or other components
- add method to insert custom conversion entries Conflicts: src/test/rpc_tests.cpp
Using pointers signals the responsibility of managing object lifetime is in the hand of the caller.
jonasschnelli
force-pushed
the
2015/03/wallet_rpc_flex
branch
from
d41f25a to
a6b659a
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
Closing in favor of #6006 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes #5744