Conversation
|
Concept ACK. |
|
ut ACK Would prefer code movement in a first commit, separated out from the rest. |
jonasschnelli
force-pushed
the
2015/04/remove_reqWallet
branch
from
451f282 to
71189e5
Compare
|
separated out the code moving |
|
Looks good. This probably wants a release note, as it's a slight RPC API-visible change. |
|
How is it visible? |
|
An exception is no longer thrown in all cases. Value::null return value comes through. |
jonasschnelli
force-pushed
the
2015/04/remove_reqWallet
branch
from
71189e5 to
b9fb692
Compare
|
This should not be the case. Value::null should only come through for the help string generation (in -disablewallet mode the cmd should not be listed under help). I tried to avoid any, even slightly, API changes. |
src/wallet/rpcwallet.cpp
Outdated
There was a problem hiding this comment.
Something weird happened to the indentation of this function, for example these continues are not indented.
There was a problem hiding this comment.
IDE issue! Will fix this.
There was a problem hiding this comment.
This means that the wallet commands will be listed in help, even if the wallet is disabled. Is that on purpose?
There was a problem hiding this comment.
No.
the !pwalletMain check (wallet disabled at runtime yes/no) will be done within the new function EnsureWalletIsAvailable(bool) :
https://github.com/bitcoin/bitcoin/pull/5992/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR40
There was a problem hiding this comment.
Ok, fair enough. Forget my other remark then.
|
|
Tested ACK, also verified that listunspent is move-only. |
9f4868a [move] move listunspent to wallet/rpcwallet.cpp (furszy) e85e4f1 [RPC] Move RPC dispatch table registration to rpcwallet code (furszy) c0bc348 [RPC] push down reqWallet [first step] (furszy) cdb80a6 [RPC] Remove not used threadsafe in CRPCCommand (furszy) Pull request description: Initial work over the RPC dispatch table registration update. Includes the following changes: 1) Remove the unused threadSafe member from every CPRCCommand. (bitcoin#5711 , second commit) 2) Remove reqWallet from every CPRCCommand (bitcoin#5992 , second commit partially). 3) Move most of the wallet RPC commands registration to the rpcwallet file (bitcoin#7307 without the `EnsureWalletIsAvailable` on every RPC call --> mainly because the wallet RPC commands will only be registered if the wallet is available). to do: Move the remaining commands that were not moved from server to rpcwallet. ---------- Next step would be bitcoin#7766 (If anyone want to tackle it, feel more than welcome to tackle it). ACKs for top commit: Fuzzbawls: ACK 9f4868a random-zebra: All good. ACK 9f4868a and merging... Tree-SHA512: cd83cdc2de81efb5cb84d39753a160b19d8ca2967a1b303d85c3279559b478352c5a4316942c7a654e9c667b5a8f5bfa18020c1b6c9e78f4c408028840d0fc86
4 participants
No description provided.