Chainparams: Explicit Consensus::Params arg in consensus functions#6024
Closed
jtimon wants to merge 1 commit intobitcoin:masterfrom
Closed
Chainparams: Explicit Consensus::Params arg in consensus functions#6024jtimon wants to merge 1 commit intobitcoin:masterfrom
jtimon wants to merge 1 commit intobitcoin:masterfrom
Conversation
main: -CheckBlock -CheckBlockHeader -ContextualCheckBlock -ContextualCheckBlockHeader
14 tasks
Contributor
Author
|
Closing for now |
This was referenced Aug 20, 2015
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit Consensus::Params arg for the main BlockHeader and Block validation functions in main.o:
-CheckBlock
-CheckBlockHeader
-ContextualCheckBlock
-ContextualCheckBlockHeader
This is part of #5970.
This functions have been chosen to be adapted first because they will be part of libconsensus.
Note that although #5995 and #5946 don't depend on this, merging this would make some of their commits easier to review (the ones that adapt these functions for consensus, which are not part of non-dependent PRs yet).