autoprune minor post-merge improvements#6058
Merged
laanwj merged 2 commits intobitcoin:masterfrom May 11, 2015
Merged
Conversation
Member
|
Please don't extend getinfo. We want to deprecate it.
|
a03a90e to
f399f46
Compare
591fcc4 to
76c2a4c
Compare
Contributor
Author
|
@sipa: right. You already told me that on IRC. My mistake, sorry. |
src/rpcblockchain.cpp
Outdated
Member
There was a problem hiding this comment.
I think we're abolishing the name "autoprune". Can you just call it "pruned" or something?
76c2a4c to
1b2e555
Compare
Contributor
|
ut ACK |
Contributor
Author
|
Renamed and added some error handling for REST and RPC when trying to access a pruned block. |
9916fc4 to
f15ef8c
Compare
Member
|
utACK |
Member
|
utACK after @sdaftuar 's nit fixed. The error message specifically mentions "pruned", so it should be sure that's actually the case. |
a4f459f to
b4ce4bd
Compare
Contributor
Author
|
Agreed with @sdaftuar. |
b4ce4bd to
619ad6c
Compare
619ad6c to
03c5687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getblockchaininfo().