depends: sanity-check sources and cached builds#6136
Merged
laanwj merged 1 commit intobitcoin:masterfrom May 14, 2015
Merged
Conversation
In some cases (Travis), sources and build caches may be moved around in-between builds, and we can't necessarily trust that everything is still intact. This introduces pre-build checks that verify against stashed checksums. Note that this will cause all sources to be re-downloaded, since cached sources weren't trustworthy before this.
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
May 14, 2015
235b3a7 depends: sanity-check sources and cached builds (Cory Fields)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pushing this up before bed in case the breakage gets worse as Europe wakes up and starts PR'ing. I'd prefer to check the build log of this PR itself before merge, but I think all should be OK as-is.
In some cases (Travis), sources and build caches may be moved around in-between builds, and we can't necessarily trust that everything is still intact. In particular, this should properly detect and recover from Travis corruption that came up this week.
This introduces pre-build checks that verify against stashed checksums.
Note that this will cause all sources to be re-downloaded, since (moved) cached sources weren't completely trustworthy before this.