Conversation
|
About 600+ PEP8 style violations in /contrib alone. Just fixed the comma spacing errors first. |
|
NACK. Don't do this - these kinds of floods of minor whitespace changes break other pulls for no good reason. |
|
@laanwj All of PEP8 violations I'm covering are in |
|
Guess the other question is should Bitcoin code even be PEP8 compliant? |
|
I also tend to NACK this. I think this PR could be something for the trivial branch https://github.com/theuni/bitcoin. |
|
Some PEP8 "violations" are worse than others. E.g. using the wrong kind of indentation would be awful. But adding spaces to almost every line so that ',' is lined up. No, that's not important. |
https://www.python.org/dev/peps/pep-0008/