There are still a lot of these cases where a const reference can be used for strings throughout the source code. Instead of many little pulls I'd prefer (for post-0.11) a pull where they're all addressed at once.

A quick git grep string -- \*.h|grep -v '&' shows at least:

• FormatParagraph
• CAlert::AppliesTo
• ParseScript()
• GetWarnings()
• ParseNetwork()
• CRPCTable::operator[](std::string name)
• CRPCTable::help(std::string name)
• HelpExampleCli
• HelpExampleRpc
• runCommand()
• CWallet::GetAccountAddresses
• CWallet::CWallet(std::string strWalletFileIn)
• CValidationState::Error
• CNode(SOCKET hSocketIn, CAddress addrIn, std::string addrNameIn = "", bool fInboundIn=false)

I'm going to update this :).

ParseNetwork() isn't suitable, because we use boost::to_lower(net); inside.

@laanwj I catched all your results and also changed a few other occurances in BOOST_FOREACH loops and in the CNode constructor (unrelated to std::string). Mind reviewing it?

@laanwj I'm going to attach a second squashme pull, which covers BOOST_FOREACH and updated to constant refs if appropriate, if you want me to do so?

utACK

I'm going to attach a second squashme pull, which covers BOOST_FOREACH and updated to constant refs if appropriate, if you want me to do so?

Yes, why not

@laanwj See 2nd commit.

utACK^2 . WIll merge this after #6121

That's fine, could be I forgot a few cases in the GUI code, but that can be a seperate pull.

utACK

Will merge after rebase.
@Diapolo can you please include getValStr() https://github.com/bitcoin/bitcoin/blob/master/src/univalue/univalue.h#L64 to return a const reference?

@laanwj Fixed 2 merge conflicts, one in rpcnet.cpp and the other in utilstrencodings.cpp and added getValStr(). Should be ready.