Skip to content

configure: Detect (and reject) LibreSSL#6244

Merged
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:conf_detect_libressl
Jun 10, 2015
Merged

configure: Detect (and reject) LibreSSL#6244
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:conf_detect_libressl

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Jun 6, 2015

This hopefully won't make sense for 0.12, but do we want it for 0.11?

@petertodd
Copy link
Contributor

utACK

@theuni
Copy link
Member

theuni commented Jun 8, 2015

I know @gmaxwell puts a good amount of time into auditing new OpenSSL releases, so I think it's worth getting his opinion here. I suspect that at this point he and @sipa may be more comfortable relying on libsecp256k1 for consensus-critical functionality than forks of OpenSSL. I certainly may be wrong in that assumption, though.

@laanwj
Copy link
Member

laanwj commented Jun 9, 2015

ACK. I think we should get this in until OpenSSL ceases to be used for the consensus.

@gmaxwell
Copy link
Contributor

gmaxwell commented Jun 9, 2015

utACK.

@theuni
Copy link
Member

theuni commented Jun 9, 2015

ok, ut ACK then.

@laanwj laanwj merged commit a5a81f7 into bitcoin:master Jun 10, 2015
laanwj added a commit that referenced this pull request Jun 10, 2015
a5a81f7 configure: Detect (and reject) LibreSSL (Luke Dashjr)
laanwj pushed a commit that referenced this pull request Jun 10, 2015
laanwj pushed a commit that referenced this pull request Jun 10, 2015
@laanwj
Copy link
Member

laanwj commented Jun 10, 2015

Cherry-picked to 0.10 as 09334e0, 0.11 as 0401aa2

reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020
Rebased-From: a5a81f7
Github-Pull: bitcoin#6244
(cherry picked from commit 09334e0)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants