Not against this.

But a pure disconnect won't prevent from a reconnect of the just kicked node.

I think the setban rpc command (#6158) would suit better for a node kick (kick and ban for 1h).

For this PR two things would be cool:

• ban disconnected nodes for 1h (or at least 10mins)
• allow removing nodes by IP without port (kick all nodes from the given IP)

I don't think it makes sense to disconnect from a peer merely because you remove it from the "persistent" addnode list...

Thanks for taking a stab at implementing this, concept ACK.

@luke-jr Agreed. This is useful functionality (now available in the GUI but not on RPC), however this is the wrong place. Let's just add a disconnectnode RPC.

+1 @laanwj RE "disconnectnode"

It is also odd that an "addnode" RPC actually performs the opposite of an "add"

@jgarzik Yeh that was my comment on the original issue too, but I thought what the hey, here's an issue I can actually take care of, I'll give it a shot.

Will take a look at adding disconnectnode later this week, leave it with me.

disconnectnode imho makes more sense to me. Maybe even just a "node" call that takes specific commands. IE node ban, node add, node disconnect.

@franko-org That would be possible, but e.g. with help it's handier to see what is available in one glance. I don't see an advantage to be particlularly thrifty with adding RPC calls. This gave us peculiar constructs like addnode remove in the first place :)

In retrospect, the RPC mechanism would have benefitted from namespacing (node.X, wallet.X etc) but doing that for one call is inconsistent.

Closing in favor of #6271