[Qt] minor optimisations in peertablemodel#6317
[Qt] minor optimisations in peertablemodel#6317jgarzik merged 1 commit intobitcoin:masterfrom Diapolo:peertablemodel
Conversation
Diapolo
commented
Jun 21, 2015
Diapolo
commented
- remove an unneeded include of net.h in peertablemodel.cpp
- add const after size() in PeerTablePriv
- remove 2x unneeded else in functions
- replace a (int) typecast by (QVariant) to use Qt style
|
Can you please remove { and } in a one-line ifs? |
|
@paveljanik @laanwj most of the time prefers { and } even for one-line ifs :). |
|
I agree with @paveljanik: most one line ifs are without brackets and i think this is according to our code style / clang style. |
|
@paveljanik @jonasschnelli Changed into one-line ifs :). |
|
@paveljanik @jonasschnelli @laanwj Do I get some ACKs, this should be easy to merge :). |
|
utACK |
|
utACK |
|
ACK |
|
@laanwj Can you please merge this trivial stuff :)? |
- remove an unneeded include of net.h in peertablemodel.cpp - add const after size() in PeerTablePriv - remove 2x unneeded else in functions - replace a (int) typecast by (QVariant) to use Qt style - remove unneeded include of peertablemodel.h from rpcconsole.cpp
|
@laanwj Ping once more. |
|
@jonasschnelli IMHO, if we still support the GUI, we need another person wo is willing or able to merge GUI pulls... it's currently frustrating! |
It seems cosmetic-only changes to the source code usually get rejected? (#6511) Still, utACK from me. |
Zcash: Also include AC_HELP_STRING -> AS_HELP_STRING (ostensibly from merging bitcoin/bitcoin#6317 but the change only occurs in the merge commit ca5e2a1, not the PR itself).
6 participants
