[Qt] fix unused function warning in scicon.cpp#6327
[Qt] fix unused function warning in scicon.cpp#6327Diapolo wants to merge 1 commit intobitcoin:masterfrom Diapolo:scicon
Conversation
- MakeSingleColorImage() is unused in non Mac, silence the compiler warning
|
This seems unnecessarily convoluted IMO... |
|
C'mon... @laanwj tried it, I didn't test it correctly and NOW the warning is gone. Please don't make it controversial if it works or give a better/easier solution and post a pull, thanks. |
|
If you're going to use #if, just remove the whole function...? |
|
I'd say to just go with it. If it removes warnings, then less confusion :) I didn't really review the code very much, but from what is said it does, it sounds good to me. (Again, I did not read the code. I glanced at it, nor have I tested it.) |
|
@luke-jr Try to #if the function and see what happens then -_-. |
|
Prefere #6328 because it's based on preprocessor macros. |
|
NACK, neither this nor #6328 is the solution we should use here. |
|
@laanwj This is weird, as your solution (current master) doesn't fix the warning, while my patch and also Lukes did fix it. My idea was to get this fixed without such a discussion... |
|
@Diapolo My point in #6328 is that non-breaking platform specific style differences should be based on a runtime decision, not on #ifdefs (or maybe one set of #ifdef at the initialization of the program, which can be overridden using an option). See my post here: #6328 (comment) |
warning