add unit tests for the decodescript rpc#6350
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jul 2, 2015
Merged
Conversation
Contributor
|
ut ACK |
Member
|
Concept ACK. Thanks for adding tests. However, wouldn't these be more appropriate in I suppose it doesn't make much of a difference as this is a stateless utility function. |
Contributor
Author
|
@laanwj Thanks for the feedback. Yes, I suppose it would make sense to move these over into the python tests. They are more integration level tests anyways. I just did them this way because I had some other changes and could run everything with a single "make check". I'll look at moving these over later today or tomorrow. |
… tests to the testing seciton of the main readme.
mruddy
force-pushed
the
raw-decode-unit-tests
branch
from
3fb4ee6 to
70ae43e
Compare
Contributor
Author
|
@laanwj Updated -- I decided to use a separate new decodescript.py file to avoid muddling the existing rawtransactions.py. I also added a short snippet to the main README referencing this set of RPC tests. |
Member
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jul 2, 2015
70ae43e add tests for the decodescript rpc. add mention of the rpc regression tests to the testing seciton of the main readme. (mruddy)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 4, 2017
Bitcoin 0.12 RPC PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6266 - bitcoin/bitcoin#6257 - bitcoin/bitcoin#6271 - bitcoin/bitcoin#6158 - bitcoin/bitcoin#6307 - bitcoin/bitcoin#6290 - bitcoin/bitcoin#6262 - bitcoin/bitcoin#6088 - bitcoin/bitcoin#6339 - bitcoin/bitcoin#6299 (partial, remainder in #2099) - bitcoin/bitcoin#6350 - bitcoin/bitcoin#6247 - bitcoin/bitcoin#6362 - bitcoin/bitcoin#5486 - bitcoin/bitcoin#6417 - bitcoin/bitcoin#6398 (partial, remainder was included in #1950) - bitcoin/bitcoin#6444 - bitcoin/bitcoin#6456 (partial, remainder was included in #2082) - bitcoin/bitcoin#6380 - bitcoin/bitcoin#6970 Part of #2074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding unit tests for the "decodescript" RPC because: