Closed
Conversation
Indexes on: - Tx Hash - Fee Rate (fee-per-kb)
StageTrimToSize will make several attempts to find a set of transactions it can evict from the mempool to make room for the new transaction. It should be aware of any required minimum relay fee that needs to be paid for by the new transaction after accounting for the fees of the deleted transactions.
Always be willing to try at least 5 different starting transactions so hitting a long chain you can't evict on your first try doesn't eliminate any chance of success.
Contributor
Author
|
Unfortunately this PR doesn't actually improve performance. cea215c appears to be the culprit, and with some tweaks to allow more fails it can do better than #6421 but not so much better that I think this is the right approach.
Closing until something is actually materially better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a couple of suggested improvements to #6421.
Feel free to cherry-pick back into that pull if you want to maintain it. Or if you'd like this pull to take over, that's fine too..
I built them on a rebased #6421 and I lost a few comment changes that differed between that pull's NO_QT_KEYWORDS commit and the one in master.