fix CBitcoinExtKeyBase template#6468
Merged
laanwj merged 3 commits intobitcoin:masterfrom Jul 27, 2015
Merged
Conversation
jonasschnelli
force-pushed
the
2015/07/base58c_extkey_fixes
branch
from
0739a38 to
c6ec07f
Compare
- fix Decode call (req. only one param) - add constructor for base58c->CExtKey
jonasschnelli
force-pushed
the
2015/07/base58c_extkey_fixes
branch
from
c6ec07f to
8d2af54
Compare
Contributor
|
ACK |
Contributor
Author
|
Added a tiny comment on top to prevent a crash when one tries to get a key from a |
src/base58.h
Outdated
There was a problem hiding this comment.
Nit: Indentation and space after begin of comment.
Member
There was a problem hiding this comment.
I'm not sure that a fixed size check is a robust solution here (also, hardwiring 74 without any kind of constant) - doesn't the underlying decode function return an error if it couldn't decode?
Member
There was a problem hiding this comment.
OK I understand now why. ret.Decode takes a fixed-size object of 74 bytes.
In that case, please define a constant.
Contributor
Author
There was a problem hiding this comment.
I didn't add a constant because fixing this is already covered in: #6215.
The Decode really expects 74 bytes (=hardcode check okay IMO)
jonasschnelli
force-pushed
the
2015/07/base58c_extkey_fixes
branch
from
93efc57 to
5c46b2b
Compare
Contributor
Author
|
Force push fixed @Diapolo nit. |
jonasschnelli
force-pushed
the
2015/07/base58c_extkey_fixes
branch
from
5c46b2b to
5c6a28c
Compare
src/base58.h
Outdated
Contributor
Author
There was a problem hiding this comment.
replaced the magic 74 with the template var Size
Member
|
ACK, apart from style nit. |
|
@sipa Let me ask, what is happening with our clang-format cleanup ;)? |
jonasschnelli
force-pushed
the
2015/07/base58c_extkey_fixes
branch
from
5c6a28c to
6f8b6d3
Compare
Contributor
Author
|
Fixed @sipa 's nit. |
laanwj
added a commit
that referenced
this pull request
Jul 27, 2015
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
- fix Decode call (req. only one param) Github-Pull: bitcoin#6468 Partial-Rebased-From: 7cb1f9f
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
- fix Decode call (req. only one param) - add constructor for base58c->CExtKey Github-Pull: bitcoin#6468 Rebased-From: 7cb1f9f
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
Github-Pull: bitcoin#6468 Rebased-From: 8d2af54
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
Github-Pull: bitcoin#6468 Rebased-From: 6f8b6d3
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
- fix Decode call (req. only one param) Github-Pull: bitcoin#6468 Partial-Rebased-From: 7cb1f9f
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
- fix Decode call (req. only one param) - add constructor for base58c->CExtKey Github-Pull: bitcoin#6468 Rebased-From: 7cb1f9f
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#6468 Rebased-From: 8d2af54
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#6468 Rebased-From: 6f8b6d3
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 3, 2017
Bitcoin 0.12 misc PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6198 - bitcoin/bitcoin#6206 - bitcoin/bitcoin#5927 - bitcoin/bitcoin#6213 - bitcoin/bitcoin#6061 - bitcoin/bitcoin#6283 (partial, remainder was pulled in #929) - bitcoin/bitcoin#6272 - bitcoin/bitcoin#6316 - bitcoin/bitcoin#6133 - bitcoin/bitcoin#6387 - bitcoin/bitcoin#6401 - bitcoin/bitcoin#6434 - bitcoin/bitcoin#6372 - bitcoin/bitcoin#6447 - bitcoin/bitcoin#6149 - bitcoin/bitcoin#6468 Part of #2074.
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jun 27, 2020
aa633c8 CBase58Data::SetString: cleanse the full vector (Kaz Wesley) 0b77f8a Improve readability of DecodeBase58Check(...) (practicalswift) dadadee Use prefix operator in for loop of DecodeBase58. (Jiaxing Wang) 305c382 base58: Improve DecodeBase58 performance. (Jiaxing Wang) 3cb418b Improve EncodeBase58 performance (João Barbosa) 4d17f71 don't try to decode invalid encoded ext keys (Jonas Schnelli) eef4ec6 extend bip32 tests to cover Base58c/CExtKey decode (furszy) 7239aaf fix and extend CBitcoinExtKeyBase template - fix Decode call (req. only one param) - add constructor for base58c->CExtKey (furszy) 13f09c3 remove unused inv from ConnectTip() (furszy) Pull request description: Coming from: * bitcoin#6468 . * bitcoin#7656 . * bitcoin#7922 * bitcoin#8736 . * bitcoin#10961 . ACKs for top commit: random-zebra: ACK aa633c8 Fuzzbawls: ACK aa633c8 Tree-SHA512: 3add3106a847b0b3d768df2c4ab5eae7d009e3820998fb5a4cd274169c64622e83ecd14dca51c31f3f6053199834129a1c6920b7ef1193632339297a041173d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
Decode()call with two parameters won't compile (not detected because the c++ temple never was evaluated).Also adds test coverage.