Update RPC generate help for numblocks to include required#6609
Closed
ChainQuery wants to merge 4 commits intobitcoin:masterfrom
ChainQuery:master
Closed
Update RPC generate help for numblocks to include required#6609ChainQuery wants to merge 4 commits intobitcoin:masterfrom ChainQuery:master
ChainQuery wants to merge 4 commits intobitcoin:masterfrom
ChainQuery:master
Conversation
added 2 commits
August 31, 2015 15:03
The `generate` RPC has no default numblocks and a numeric value is required.
…quired Update rpc generate help to include "required"
Member
|
Can you remove the merge-commit from the branch, please? |
Contributor
|
ACK after squashing (remove merge commit). |
Member
|
Better to be explicit, IMO (defaults are annoying with positional arguments). Apart from that, this call is only used for testing (regtest), adding a default doesn't make much sense. ACK after removing the spurious commit. |
added 2 commits
September 3, 2015 13:08
Author
|
Sorry folks, still figuring out git, going to close this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generateRPC has no defaultnumblocksand a numeric value is required.