timedata: Prevent warning overkill#6728
Conversation
The "please check your computer's data and time" message when the clock
deviates from the network currently generates an overkill of messages:
orion@lethe:~/bitcoin$ src/bitcoind
Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
In the log:
2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
Remove one level of 'Warning:' and reduce to one log message.
|
ACK |
|
utACK. |
|
Tested ACK 9fea833 on fed23 with bitcoind. Though, QT will crash (regardless of this PR). |
Can you explain that more detailed? Why is QT crashing? |
|
Probably better to open a separate issue, if there isn't one already. On Monday, September 28, 2015, Jonas Schnelli [email protected]
|
|
Could not crash Fedora and OSX when set my local date +2 day and did 5min IBD on testnet. |
|
Fedora 23 is alpha, so likely it's a local issue with modal dialogs on my box. Doesn't hold back this PR. |
|
date and time are correct but still load core bitcoin network |
|
A GUI crash is a serious issue, however please open a new issue for that with more information: debug.log tail, any messages, traceback if possible. It cannot be related to the trivial message change here. |
9fea833 timedata: Prevent warning overkill (Wladimir J. van der Laan)
|
Can no longer reproduce the GUI crash... |
Bitcoin 0.12 misc P2P/Net PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5288 - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258 - bitcoin/bitcoin#6561 - bitcoin/bitcoin#6728 - bitcoin/bitcoin#6829 - bitcoin/bitcoin#6974 - bitcoin/bitcoin#7075 - bitcoin/bitcoin#7166 Part of #2074.
5 participants
The "please check your computer's data and time" message when the clock deviates from the network currently generates an overkill of messages :-)
In the log:
Remove one level of 'Warning:' and reduce to one log message.
Edit: An open question is whether this message should be translated at all, currently it is.