Trivial: start the help texts with lowercase#6739
Conversation
|
I think it would make sense to also change from --disable-zmq to --enable-zmq (to fit the current style --enable-wallet etc.) |
|
Looks like I misread what you wrote. I personally prefer |
|
If it's enabled by default, the feature logically requires a --disable-foo. And the opposite, for anything disabled by default. (and as seen in #6733 and elsewhere, features should be built, even if runtime-disabled) |
|
Right - the reasoning would be thus: you never have to pass BTW: if we want to be consistent, we should be consistent, looking at But re: libressl see also #6732 |
|
Boost one is an upstream issue in http://www.gnu.org/software/autoconf-archive/ax_boost_base.html - I do not want to divert. |
|
Ad enable/disable rewrites: This is a quick scan of the current configure here. |
|
OK, fair enough, thanks for checking. Just want to avoid zillions of pulls that change the case of a single character, so if we could have done multiple at once it would be nice. But yes the boost one has to be changed upstream... |
|
Nod - a pull request to change them all at once |
96106f0 [Trivial] start the help texts with lowercase (paveljanik)
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
All
configure --helptexts should start with a lowercase letter.