ping @jmcorgan @jonasschnelli

What? Why? Static linking makes sense for the Linux binaries, but not for Mac/Windows. It certainly shouldn't break non-static builds either way!

as mentioned on IRC, the zmq rpc tests currently yield:

Running testscript zmq_test.py...
Initializing test directory /tmp/ramfs/tmp/testnnj2Pf
Assertion failed!

Program: Z:\home\cory\dev\bitcoin2\src\bitcoind.exe
File: zmq/zmqpublishnotifier.cpp, Line 91

Expression: psocket

abnormal program termination

With that assertion removed, it (appears to) finish successfully.

I don't see how that is at all related to this PR...

@luke-jr We make the same assumption about miniupnpc for sure, and i believe there are assumptions for boost/qt as well.

I could make the -DZMQ_STATIC an artifact of depends instead though, if you'd prefer.

@luke-jr Our tests have never been run against zmq+windows binaries afaik.

But that assertion/problem seems entirely unrelated to static linking...?

@luke-jr I'm not aware of anyone running the tests against libzmq dll's via mingw either. Assuming the problem isn't local, I assumed it was a windows issue.

Regardless, I'm just reporting what I saw :)

Nice!
Concept ACK.

I'll have to replicate @theuni test failure, then I'll dig into this.

Static linking makes sense for the Linux binaries, but not for Mac/Windows

We link all dependency libraries statically on Windows and Mac as well as Linux. On no platform do we actually perform a 'static build' as this would mess with ASLR...

Any progress here?

Last chat with @theuni on IRC he hadn't returned to the issue, nor have I.

Does this have to be solved before the 0.12 release?

I'm not familiar enough with zmq to know how helpful it is in Windows. My hunch is that the overlap would be small enough to ignore until someone willing/able to test comes along.

I'd rather that than blindly enable it and risk untested codepaths.

OK, yes, zmq on windows doesn't seem like a very common use-case. Thanks for the explanation.

(I'm not even convinced it should be enabled in any releases by default, I mean it has to statically link zmq instead of use the one on the system, which may be incompatible in practice)

Closing this for now, as it seems to be inactive. Let me know if you start work on this again so I can reopen.