doc: add comment explaining initial header request#6829
Merged
laanwj merged 1 commit intobitcoin:masterfrom Oct 20, 2015
Merged
doc: add comment explaining initial header request#6829laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Add a comment that explains why the initial "getheader" requests are made starting from the block preceding the currently best one. Thanks to sdaftuar for the explanation!
Contributor
|
ACK |
Contributor
|
utACK |
1 similar comment
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Oct 20, 2015
53b86d0 doc: add comment explaining initial header request (Daniel Kraft)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 19, 2021
Bitcoin 0.12 misc P2P/Net PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5288 - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258 - bitcoin/bitcoin#6561 - bitcoin/bitcoin#6728 - bitcoin/bitcoin#6829 - bitcoin/bitcoin#6974 - bitcoin/bitcoin#7075 - bitcoin/bitcoin#7166 Part of #2074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a comment that explains why the initial "getheader" requests are made starting from the block preceding the currently best one.
Thanks to @sdaftuar for the explanation!
I slightly reformulated the code, since I believe it is clearer (particularly with the explanation) that way. But if you disagree, let me know and I'll revert the code change and just add the comment.