Add explicit shared_ptr constructor due to C++11 error#6899
Add explicit shared_ptr constructor due to C++11 error#6899laanwj merged 1 commit intobitcoin:masterfrom AtakamaLLC:cpp11
Conversation
|
utACK |
There was a problem hiding this comment.
Heh, on its own, this just looks like const = 0.
|
I really do not want to carry around and maintain a patch for leveldb for superfluous warnings. |
|
Agree w/ @gmaxwell - we want to avoid patching leveldb |
|
@mcelrath, given the above, maybe just the |
|
Dunno, I wouldn't want leveldb in the core in the first place... I haven't analyzed these sign comparisons to see if they could overflow, but I find the idea pretty scary. But I don't think this is an argument worth having. Will backout everything except the rpcserver change. We can remove the -Wno-self-assign when we actually switch to C++11. |
mcelrath
changed the title
|
yes, definitely just fix the error. If the warnings point at critical problems, then hiding the warnings by fuzzing the types a bit is a disservice. utACK |
|
reACK |
a83f3c2 Add explicit shared_ptr constructor due to C++11 error (Bob McElrath)
|
FWIW, the unsigned change was all to do with the "n" parameter of a Bloom filter, which is its number of bits, and is nonsensical for it to be negative. I'm sure these warnings have nothing to do with C++11 mode... |
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 Closes #1593 and #1856.
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 - bitcoin/bitcoin#6640 - bitcoin/bitcoin#8139 - bitcoin/bitcoin#8839 Closes #1593 and #1856.
5 participants
Clean up some warnings (and one error) when compiling in C++11 mode with g++ and clang. Details:
There are other warnings due to a few uses of std::auto_ptr which is deprecated. When we switch to compiling in C++11 mode by default, we'll have to convert these to std::unique_ptr, but this is a non-backwards compatible change so can't be done now.