build: If both Qt4 and Qt5 are installed, use Qt5#6938
Conversation
laanwj
force-pushed
the
2015_11_prefer_qt5
branch
from
0aaf068 to
7701b0e
Compare
|
Concept ACK |
|
Please also remove |
|
Concept ACK On Wednesday, November 4, 2015, paveljanik [email protected] wrote:
|
But that means you may end up without a GUI at all, if the proper dependencies cannot be found. Is that the intended behavior? If not, actively setting a GUI makes sense |
|
utACK!
We should definitively keep this. |
|
@laanwj IMO |
|
I think |
|
I'm happy with setting the |
|
agree with @paveljanik |
|
I have no clue what happens if you do --with-gui without argument. Have you tested? You can do --without-gui if you want to build without GUI. The default if you don't provide it is auto, which means that (with this pull), it will
I have no intention of changing the semantics there. The only thing I'm changing is what Qt is selected by default, which IMO should be Qt5. |
|
Agree. --with-gui already does auto-select. But right,.. as @laanwj mention, this PR would only change this auto-behavior to Qt5 instead of Qt4. Do we need adaptation here:? |
laanwj
force-pushed
the
2015_11_prefer_qt5
branch
from
7701b0e to
dbacc69
Compare
|
@jonasschnelli good catch, updated |
If both Qt4 and Qt5 development headers are installed, use Qt5. Building against Qt5 should be encouraged as that is where active development happens.
|
I just want to save the work again at qt6 bumb: just do not document the qt version in the |
dbacc69 build: If both Qt4 and Qt5 are installed, use Qt5 (Wladimir J. van der Laan)
|
Shouldn't the preferred Qt be based on what the OS default is configured for...? |
|
@luke-jr That may have been a better choice in the beginning, but right now, we're slowly moving away from Qt4. I expect to retain compatibility for the foreseeable future, but the GUI experience may be worse than Qt5, so we pick what is best for us. |
|
Note: I need to set |
|
Tested ACK. Nice, bitcoin-qt looks so much more clean when built with qt5! (No missing icons, styles, etc.) |
6 participants
If both Qt4 and Qt5 development headers are installed, use Qt5. Building against Qt5 should be encouraged as that is where active development happens.