[trivial] Cleanup maxuploadtarget (doc & log)#6958
Conversation
qa/rpc-tests/maxuploadtarget.py
Outdated
There was a problem hiding this comment.
Hmm.... i think either we take in the MAX_BLOCK_SIZE constant (controversial) or we drop the comment.
There was a problem hiding this comment.
Is this exposed via rpc? I always like to do grep -r 'CONSTANT' bitcoin/ when touching a constant to see it's usage.
|
utACK. Thanks! I think we should extend the documentation about -maxuploadtarget. How it actually works under the hood (short, 1-2 sentence). I can do this after this has been merged. |
maflcko
force-pushed
the
MarcoFalke-2015-maxupload
branch
2 times, most recently
from
48876a8 to
9f61ffe
Compare
|
Two commits that could make sense for this PR (2nd one maybe independent):
Both are written in my swenglish (swiss english). Feel free (or obligated) to correct and rewrite everything. |
maflcko
force-pushed
the
MarcoFalke-2015-maxupload
branch
from
9a81fb8 to
3fb48ff
Compare
|
utACK |
|
Looks ready to merge!? |
There was a problem hiding this comment.
Maybe a link to https://github.com/jonasschnelli/bitcoin/blob/2015/11/doc_traffic/doc/reducetraffic.md (once it's merged) can be added here ? Something like "for more details on reducing traffic, see ...".
|
utACK besides my little nit. |
* log: nMaxOutboundLimit is in bytes * log: Hide misleading -maxuploadtarget=0 warning * qa : Minor cleanup to maxuploadtarget rpc tests * net: Use DEFAULT_MAX_UPLOAD_TARGET = 0
maflcko
force-pushed
the
MarcoFalke-2015-maxupload
branch
from
3fb48ff to
2bf3771
Compare
|
@jtimon Done. |
maflcko
force-pushed
the
MarcoFalke-2015-maxupload
branch
from
cdfb9e0 to
9c3ee3b
Compare
|
Great, re-utACK |
Introduce -maxuploadtarget Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6622 - bitcoin/bitcoin#6987 - bitcoin/bitcoin#6958 - bitcoin/bitcoin#6984 - bitcoin/bitcoin#6999 Part of #2074.
4 participants
@jonasschnelli this fixes #6890.