Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN.#7016
Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN.#7016laanwj merged 1 commit intobitcoin:masterfrom gmaxwell:without_EVENT_LOG_WARN
Conversation
|
Not the end of the world if this isn't wanted; it's needed on Fedora 19, and (I think) Fedora 20 which some of my old test hosts are still running and I was tired of patching around it locally. Seems like a mostly harmless compatibility boost. |
src/httpserver.cpp
Outdated
There was a problem hiding this comment.
What does LogPrint without a category do? Did you mean this to be LogPrintf?
There was a problem hiding this comment.
Gah. What it doesn't to is it doesn't fail to compile; so much for type safety. Good spotting; thats what I get from changing from the always debug to always no debug at the last second. :-/
|
utACK |
|
Concept ACK Though what I think is interesting here is that we have a BTW: If you plan on doing any benchmarking or advanced testing, please use an up to date libevent. There have been various nasty bugs fixed over time. |
|
Indeed, _EVENT_LOG_WARN is there and has the same definition. |
This uses _EVENT_LOG_WARN instead, which appears to be defined in the old versions of libevent that I have on some systems.
aee22bf Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN. (Gregory Maxwell)
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 Closes #1593 and #1856.
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 - bitcoin/bitcoin#6640 - bitcoin/bitcoin#8139 - bitcoin/bitcoin#8839 Closes #1593 and #1856.
5 participants
This means that some low priority libevent errors may get logged with
debugging disabled when they wouldn't otherwise. In a quick check it
did not appear to be chatty.