Tests: Explicitly set chain limits in replace-by-fee test#7137
Merged
laanwj merged 1 commit intobitcoin:masterfrom Dec 1, 2015
Merged
Tests: Explicitly set chain limits in replace-by-fee test#7137laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
Nice, utACK cfdc662
+1 |
Contributor
|
ACK |
laanwj
added a commit
that referenced
this pull request
Dec 1, 2015
cfdc662 Explicitly set chain limits in replace-by-fee test (Suhas Daftuar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chains built in this test will fail with the lower chain limits introduced by #6771. I just changed them to be higher to avoid rewriting these tests, which aren't meant to test those chain limits anyway.
@petertodd Is it time to remove the qa/replace-by-fee directory? I can do that cleanup in this pull if you like.
Fixes #7120