Name union to prevent compiler warning#7146
Merged
laanwj merged 1 commit intobitcoin:masterfrom Dec 2, 2015
Merged
Conversation
Member
|
ACK |
Member
|
But if you're going to give it a name anyway, better make it a descriptive one, like "direct_or_indirect"? |
Contributor
Author
|
I was about to use |
Contributor
|
ACK once it uses a proper name. |
Contributor
Author
|
@jonasschnelli And do you have an opinion the correct name? Do you agree with |
Member
Better than |
f05f2d0 to
1812de9
Compare
Contributor
|
|
Contributor
|
ACK 1812de9 |
Contributor
Author
|
OK, thanks for your opinions. Name update. |
Member
|
utACK 1812de9 mod travis |
Member
|
|
laanwj
added a commit
that referenced
this pull request
Dec 2, 2015
1812de9 Name union to prevent compiler warning (Pavel Janík)
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
May 22, 2020
…zation 30e975e Lift prevector default vals to the member declaration (random-zebra) 3217b2b Name union to prevent compiler warning (random-zebra) Pull request description: Two simple additions to `prevector` class: - name the union, to prevent compiler warnings emitted by clang (from bitcoin#7146) - use non-static data member initializers for `_size` and `_union` (from bitcoin#14266) ACKs for top commit: furszy: utACK 30e975e Fuzzbawls: utACK 30e975e Tree-SHA512: f7a0dd55bbf2df0b9d0d72967ac00c476aebde936499cd3d1b5a7552aded6b7022c5a23c859eaa3599875f2c2c7bd737afdda3cd31db9d7e2c5dfdca7f0c9809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #6914, a lot of compiler warnings are emitted by
clang: