net: Fix sent reject messages for blocks and transactions#7179
Merged
laanwj merged 2 commits intobitcoin:masterfrom Dec 10, 2015
Merged
net: Fix sent reject messages for blocks and transactions#7179laanwj merged 2 commits intobitcoin:masterfrom
laanwj merged 2 commits intobitcoin:masterfrom
Conversation
Ever since we bitcoin#5913 have been sending invalid reject messages for transactions and blocks.
Contributor
|
Worth adding a regression test? |
Member
Author
|
Would make sense. |
Member
Author
|
To be clear, this solves the following issue: Normal reject message Reject message from 0.11.99+ Reason seems empty, and part of the reason message ends up in the "hash". This is due to the reject code being sent as multiple bytes instead of one, misaligning the message. Edit: trying to think of a test. Hopefully it could fit somewhere in the Python P2P test framework, without creating a new script. |
Member
|
utACK 9fc6ed6 |
Member
Author
|
Added basic tests for rejection of blocks and transactions. |
laanwj
force-pushed
the
2015_12_fix_reject_message
branch
3 times, most recently
from
40811fe to
5eea9ce
Compare
Extend P2P test framework to make it possible to expect reject codes for transactions and blocks.
laanwj
force-pushed
the
2015_12_fix_reject_message
branch
from
5eea9ce to
2041190
Compare
Member
Author
|
@sdaftuar Mind taking a look at the test changes? |
Member
|
Sure, will take a look.
|
Member
|
post-merge ACK. The extension to the test framework seems like a good idea! |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Extend P2P test framework to make it possible to expect reject codes for transactions and blocks. Github-Pull: bitcoin#7179 Rebased-From: 2041190
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Extend P2P test framework to make it possible to expect reject codes for transactions and blocks. Github-Pull: bitcoin#7179 Rebased-From: 2041190
Member
Author
|
This is cherry-picked to 0.12 as 44fef99, removing needs backport label |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 17, 2021
ZIP 239 preparations 4 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5913 - Replaces #3111. - Includes an extra commit included by upstream in the merge outside the PR. - bitcoin/bitcoin#6519 - bitcoin/bitcoin#7179 - bitcoin/bitcoin#7853 - bitcoin/bitcoin#7960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since we #5913 have been sending invalid reject messages for transactions and blocks.