Note that reviewers should mention the id of the commits they reviewed.#7185
Note that reviewers should mention the id of the commits they reviewed.#7185laanwj merged 1 commit intobitcoin:masterfrom pstratem:2015-12-07-contributingackcommit
Conversation
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
And a dot at the end of the sentence.
There was a problem hiding this comment.
I do not see any dot there Luke 8)
|
Not that it should be trusted verbatim (I guess?), but if any changes occur after a comment, then the changed commits will be moved below the original comment. |
|
👍 |
|
Agree that this is useful in some cases, but as long as this is a manual step I don't really want to force it on everyone. |
|
@laanwj sure thus, SHOULD instead of MUST |
|
Ok, concept ACK, agree on the style nits. |
|
@luke-jr is that acceptable? |
|
Sure |
|
ACK, after updating the commit message. It still mentions id rather than hash. |
|
ACK 7ad0537 |
|
ACK pstratem@7ad0537 |
1 similar comment
|
ACK pstratem@7ad0537 |
|
@fanquake nit picked |
|
ACK pstratem@e1030dd |
|
ACK e1030dd |
e1030dd Note that reviewers should mention the commit hash of the commits they reviewed. (Patrick Strateman)
|
another great example of why this is necessary #6451 |
…y reviewed. Github-Pull: bitcoin#7185 Rebased-From: e1030dd
8 participants
No description provided.