Merged
Conversation
Member
Author
|
If someone feels like testing that |
Contributor
|
Confirmed as move-only expect of the new |
maflcko
force-pushed
the
MarcoFalke-2015-WalletTests
branch
from
fa55a8b to
fafd093
Compare
Member
|
utACK Those changes make sense to me. |
laanwj
added a commit
that referenced
this pull request
Jan 5, 2016
fafd093 [wallet] Adjust pruning test (MarcoFalke)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #4906.
Please review commit-by-commit:
[100] * 2, [10] * 12and a target value of 221 the old code as well as the new code always return[100] * 2, [10] * 3, regardless of the number of iterations, etc.To actually test pruning, one needs a sufficient amount of "big coins" so that the random approximation misses at least one big coin even if iterations=1000 (default). Thus, "smaller coins" get added by the algorithm. (But the algorithm does not yet know they are not sufficient and will later be useless, after executing the second pass)
Second commit: Useclang-formatbecause the code style is really messed up here. (Reminder to use ?w=0 flag on GitHub to disable white space diff) // moved to a later pull