[RPC] getblock: Added help text for chainwork value#7232
[RPC] getblock: Added help text for chainwork value#7232laanwj merged 1 commit intobitcoin:masterfrom
Conversation
instagibbs
changed the title
|
@instagibbs yes; that description was written by me based upon my reading of the code. |
|
ACK |
instagibbs
changed the title
src/rpcblockchain.cpp
Outdated
There was a problem hiding this comment.
I don't understand this sentence. I like (string) Expected number of hashes required to produce the current chain (in hex) better.
There was a problem hiding this comment.
What don't you understand about it specifically? Would:
(string) Expected number of hashes required to produce the chain up to this block (in hex)
be better? As-is it's ambiguous to what "current chain" means. In getblockchaininfo it clearly means the valid chain with most work.
There was a problem hiding this comment.
block header hashes
is not immediately clear what this means. Usually blocks with hashes that don't hit the diff are not considered valid, so they are not counted. Then "estimated" gives the hint that they are counted as well.
|
Updated wording re: @MarcoFalke comments. |
instagibbs
force-pushed
the
getblockhelp
branch
from
9478fc9 to
94bdd71
Compare
|
utACK 94bdd71 |
94bdd71 Added help text for chainwork value (Gregory Sanders)
|
utACK |
6 participants
I took the text from bitcoin.org's description. @harding Is this originally from there?
edit: Changed the wording