Blocksize: Some small preparations for a blocksize hardfork#7238
Blocksize: Some small preparations for a blocksize hardfork#7238jtimon wants to merge 2 commits intobitcoin:masterfrom
Conversation
…tion number This is a no-op change. For now, everything passes MAX_BLOCK_SIZE / 60, so the result matches what it would've before. Tests use a number equal to the number of transactions where necessary, to ensure that they're never rejected when blocksizesize isn't being tested.
|
What's the reasoning for nMaxTransactions? |
|
More flexibility in the code for when MAX_BLOCK_SIZE is no longer a constant. |
|
Perhaps my question wasn't clear -- why limit the number of transactions at all? We should probably do overflow checks (which would mean a real limit of 4 billion transactions), but I'm not sure why this would ever be a purposefully, further constrained parameter. |
|
I guess another option would be to just replace |
|
That check is really just a sanity check, and IMHO shouldn't be there as Merkle trees are used for other purposes. There is no reason to explicitly limit the number of transactions, and a generic merkle tree validator shouldn't have such a limitation built into it. |
|
Ok, so you suggest to just remove the check then? |
3 participants
Replaces #6625 (contains commits from #6526).