Skip to content

[qa] Test walletpassphrase timeout#7320

Merged
laanwj merged 1 commit intobitcoin:masterfrom
maflcko:Mf1601-rpcWalletPass
Jan 18, 2016
Merged

[qa] Test walletpassphrase timeout#7320
laanwj merged 1 commit intobitcoin:masterfrom
maflcko:Mf1601-rpcWalletPass

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jan 8, 2016

Test case for #7316

Test code: $ git checkout fadceb7;make;BITCOIND=bitcoin-qt qa/pull-tester/rpc-tests.py keypool

...
Running testscript keypool.py ...
Initializing test directory /tmp/testqf3QO4
Assertion failed: 1452255264 != 0

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 8, 2016

Nice!
utACK.

But this actually does not test the issue #7316, because the reported issue can only happen when you run bitcoin-qt with -server=1.

@maflcko
Copy link
Member Author

maflcko commented Jan 8, 2016

@jonasschnelli See my "test code" ;)

Are you still working on the BITCOIND=bitcoin-qt nightly rpc tests?

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 8, 2016

@MarcoFalke: Ah. Right. Your testcode looks good. Indeed, this would catch #7316.

Are you still working on the BITCOIND=bitcoin-qt nightly rpc tests?

It's relatively far down on my priority list. But not given up...

laanwj
laanwj reviewed Jan 9, 2016
View reviewed changes
qa/rpc-tests/keypool.py Outdated
Copy link
Member

@laanwj laanwj Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, but setting a timeout of 1 and then waiting a second is too close. A slight mistiming (e.g. busy machine) would result in a race condition, what about waiting 2 seconds instead?

@maflcko maflcko force-pushed the Mf1601-rpcWalletPass branch from fadceb7 to fa1cb1a Compare January 9, 2016 15:54
luke-jr
luke-jr reviewed Jan 15, 2016
View reviewed changes
qa/rpc-tests/keypool.py
Copy link
Member

@luke-jr luke-jr Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this ought to actually try to do something to test the wallet relocking?

@laanwj laanwj merged commit fa1cb1a into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
@laanwj
Merge pull request #7320
d3dfc6d 
fa1cb1a [qa] Test walletpassphrase timeout (MarcoFalke)
@maflcko maflcko deleted the Mf1601-rpcWalletPass branch January 18, 2016 10:21
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Feb 12, 2016
@luke-jr
[qa] Test walletpassphrase timeout
3493110 
Github-Pull: bitcoin#7320
Rebased-From: fa1cb1a
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Apr 5, 2016
[qa] Test walletpassphrase timeout
3316552 
Github-Pull: bitcoin#7320
Rebased-From: fa1cb1a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maflcko @jonasschnelli @laanwj @luke-jr