libconsensus-p2a: Preparations to decouple libconsensus from coins.o#7564
Closed
jtimon wants to merge 3 commits intobitcoin:masterfrom
Closed
libconsensus-p2a: Preparations to decouple libconsensus from coins.o#7564jtimon wants to merge 3 commits intobitcoin:masterfrom
jtimon wants to merge 3 commits intobitcoin:masterfrom
Conversation
jtimon
force-pushed
the
libconsensus-p2a-coins-cpp-interface-0.12.99
branch
from
7f431c9 to
e10daec
Compare
…ge_interfaces_cpp.h
CCoins implements CCoinsInterface CCoinsView implements CUtxoView (not fully, but CCoinsViewCache implements the rest)
jtimon
force-pushed
the
libconsensus-p2a-coins-cpp-interface-0.12.99
branch
from
e10daec to
b42a5b2
Compare
Contributor
Author
|
Closing for now. Will be reopened if #7563 is merged. Review will still be valuable and traceable even if the PR gets replaced in the future (although I hope to just reopen it at some point after 12.1 is released). EDIT: Why close then? I had violated my self-imposed policy of no more than 5 open PRs to master at a time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to #7563 but with coins instead of chain.o
Replaces "Refactor: Create CCoinsViewEfficient interface for CCoinsViewCache #5747 [coins]".
Unnecessary dependencies:
This doesn't need to depend on #7563, but the first commit in both PRs writes the same file.