[doc/log] Fix markdown syntax and line terminate LogPrint#7617
Merged
laanwj merged 3 commits intobitcoin:masterfrom Mar 1, 2016
Merged
[doc/log] Fix markdown syntax and line terminate LogPrint#7617laanwj merged 3 commits intobitcoin:masterfrom
laanwj merged 3 commits intobitcoin:masterfrom
Conversation
Member
maflcko
commented
Feb 27, 2016
maflcko
commented
- Fix three minor issues in the 0.12 historical release notes.
- Fix some links
- Yet another Make sure LogPrintf strings are line-terminated #6497
maflcko
force-pushed
the
Mf1602-trivial9
branch
3 times, most recently
from
cd7f0ce to
fa444e9
Compare
maflcko
changed the title
maflcko
force-pushed
the
Mf1602-trivial9
branch
from
fa444e9 to
fa100ec
Compare
Member
|
ACK fa100ec |
Contributor
|
ACK fa100ecb9795fe4a6c4a0f928fc8e9858e979303 |
Contributor
|
ACK |
Member
|
Tangential: Would be awesome to have a lint-er that checked these kinds of things: LogPrint[f]/strprintf number of arguments versus number of %, line breaks (although there are cases where you explicitly don't want them, but I they could be marked insome way). |
src/net.cpp
Outdated
Member
There was a problem hiding this comment.
Are you sure this is correct? I think this was supposed to be un-terminated, because other message-related commands continue the logging.
Member
Author
There was a problem hiding this comment.
I remember I saw at least one instance which was wrong but I can't recall which one as I have deleted the debug.log in the meantime. I have reverted for now and will look into this later.
laanwj
added a commit
that referenced
this pull request
Mar 1, 2016
laanwj
pushed a commit
that referenced
this pull request
Mar 11, 2016
zander
pushed a commit
to bitcoinclassic/bitcoinclassic
that referenced
this pull request
Apr 22, 2016
- Fix doxygen comment for payTxFee - [doc] Fix markdown - Make sure LogPrintf strings are line-terminated Github-Pull: bitcoin#7617 Rebased-From: fa06ce0 fa97f95 fa26652 Conflicts: README.md doc/release-process.md
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Dec 18, 2019
Bitcoin 0.12 cleanup PRs 2 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6631 - bitcoin/bitcoin#6664 - Only the first commit (we already had the second through bitcoin/bitcoin#6825). - bitcoin/bitcoin#6669 - bitcoin/bitcoin#6887 - Only the non-QT parts. - bitcoin/bitcoin#6962 - bitcoin/bitcoin#6822 - Only first and third commits (we already had the second through an earlier PR). - bitcoin/bitcoin#7136 - Excludes Travis CI changes, and fixes to documents we don't have anymore. - bitcoin/bitcoin#7084 - bitcoin/bitcoin#7509 - bitcoin/bitcoin#7617 - bitcoin/bitcoin#7726 Part of #2074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.