Avoid "Unknown command" messages when receiving getaddr on outbound c…#7642
Merged
sipa merged 1 commit intobitcoin:masterfrom Mar 9, 2016
Merged
Avoid "Unknown command" messages when receiving getaddr on outbound c…#7642sipa merged 1 commit intobitcoin:masterfrom
sipa merged 1 commit intobitcoin:masterfrom
Conversation
rebroad
force-pushed
the
GetAddrUnknownCommand
branch
from
18d8158 to
d84ea1a
Compare
Member
|
utACK Tiny nit: can you use a less wide commit title? See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for example. |
Member
|
utACK rebroad@d84ea1a |
Member
|
utACK d84ea1a |
Contributor
|
utACK. e.g. else if (strCommand == NetMsgType::HEADERS && !fImporting && !fReindex) // Ignore headers received while importing |
rebroad
force-pushed
the
GetAddrUnknownCommand
branch
from
d84ea1a to
9988554
Compare
Contributor
Author
|
@sipa commit reworded |
sipa
added a commit
that referenced
this pull request
Mar 9, 2016
…on outbound c… 9988554 No "Unknown command" for getaddr command. (R E Broadley)
Member
|
Could be tagged with "Needs backport" |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 27, 2016
…onnections. Github-Pull: bitcoin#7642 Rebased-From: d84ea1a
Member
|
Backported as part of #7938. Removing label 'Needs backport'. |
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Jun 28, 2016
…onnections. Github-Pull: bitcoin#7642 Rebased-From: d84ea1a
aistrych
added a commit
to aistrych/Pink2
that referenced
this pull request
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onnections.
Replaces #6344 and addresses concerns raised (i.e. now logs this exceptional event).