Add curl to Gitian setup instructions#7658
Conversation
curl is required to fetch dependencies [ci skip]
|
ACK |
|
The gitian descriptors should be installing this now, although I suppose this saves time. |
|
As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97 So this pull seems like a good place to revert #7614? |
|
They're only needed on the guest system. |
Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system. Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories |
|
Without this patch, |
|
@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list. |
laanwj
changed the title
ce41cf0 Add curl to Gitian setup instrustions (BtcDrak)
curl is required to fetch dependencies Github-Pull: bitcoin#7658 Rebased-From: ce41cf0
|
Backported as part of #7938. Removing label 'Needs backport'. |
curl is required to fetch dependencies Github-Pull: bitcoin#7658 Rebased-From: ce41cf0
5 participants
curl is required to fetch dependencies
requires backport to all branches
[ci skip]