[Qt] RPC-Console: support nested commands and simple value queries by jonasschnelli · Pull Request #7783 · bitcoin/bitcoin

jonasschnelli · 2016-04-01T15:15:03Z

this is currently limited to the QT RPC Console, but I'm happy to extend/refactor this to make it useable in bitcoin-cli

Commands can be executed with bracket syntax, example: getwalletinfo().
Commands can be nested, example: sendtoaddress(getnewaddress(), 10).
Simple queries are possible: listunspent()[0][txid]
Object values are accessed with a non-quoted string, example: [txid].

Fully backward compatible.
generate 101 is identical to generate(101)
Result value queries indicated with [] require the new brackets syntax.
Comma as argument separator is now also possible: sendtoaddress,<address>,<amount>
Space as argument separator works also with the bracket syntax, example: sendtoaddress(getnewaddress() 10)

No dept limitation, complex commands are possible:
decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]

luke-jr · 2016-04-01T18:34:10Z

Isn't this going a bit overboard for debugging tools? (OTOH, it's only about 150 LOC...)

maflcko · 2016-04-01T18:44:55Z

I think this is useful. An alternative proposed was to use variables a = getnewaddress sendtoaddress a 10, but this pull is fine as well.

jonasschnelli · 2016-04-01T18:53:33Z

Isn't this going a bit overboard for debugging tools? (OTOH, it's only about 150 LOC...)

It is a "luxury extension", right. But given the time some of us have spent in the console repeating and copy-pasting commands out- and input, I think it worth taking this in.
Also, I don't see critical risks for this.

IMO we should also extend bitcoin-cli to support nested commands. It simply increases productivity with that tool.

laanwj · 2016-04-02T05:41:05Z

I like this concept. I initially had @luke-jr 's concern as well. But only a bit of code added, and it's well-contained.

It's not just luxury: it's useful for cases like #7599 where someone wants to insert the output of a previous command into a new one, but it's too long for copy pasting.

IMO we should also extend bitcoin-cli to support nested commands. It simply increases productivity with that tool.

Not sure there. bitcoin-cli is simply an entry point and you can use whatever scripting you want in the shell that calls it.

For the GUI debug console, which is essentially it's own bash, this makes more sense.

I'm all for a fancy ncurses-based interactive client, but that should not be bitcoin-cli.

paveljanik · 2016-04-02T10:52:22Z

On the other hand, many advices read 'Run getsomething' and so. This will bring another "fork" - you have to also add that you have to run this in Debug console or via bitcoin-cli, because the syntax will "fork".

Concept ACK (I'd also like to see this in bitcoin-cli)

luke-jr · 2016-04-02T10:57:52Z

Almost tempting to make it server-side, if we're using long output-inputs... but this seems fine (Concept ACK) as-is; further improvement can wait for another PR.

sipa · 2016-06-02T14:10:51Z

Would it be possible to abstract out this functionality in a separate commit (including the existing RPC parsing logic from the Qt console) and move it to rpc/server.cpp, as an actual RPC call that just takes a string argument with a command to parse?

That would make it both more usable (by exposing it as RPC, bitcoin-cli and other tools can use it too), and more testable (we can have RPC tests for it), without complicating the change much.

jonasschnelli · 2016-06-02T14:14:26Z

I have though about that but I wasn't sure if we should delegate the parsing/executing of nested command to the server. This PR would do the parsing "client side". We could also factor out the parsing and use it client-side (Qt / bitcoin-cli).

But I agree, it could be useful server-side.

sipa · 2016-06-02T14:21:23Z

Yes, I agree having it client side is useful. My main reason for suggesting abstracting it out it because I don't think it's very hard, and would make the parsing logic much easier to test.

UniQredit · 2016-07-19T05:08:31Z

This would save a hell lot of time and copy/pasting

jonasschnelli · 2016-07-19T15:22:34Z

Finally rebased this great PR and refactored the parsing logic into rpc/server.cpp
Added some unit tests

This could now be simply extended to the RPC server, although, nested commands could be resource and time hungry.

maflcko · 2016-07-19T15:29:35Z

src/test/rpc_tests.cpp

There is no whitespace at the end?

jonasschnelli · 2016-07-20T13:27:26Z

Fixed nits. Had to add client.cpp to libbitcoin_server_a. Should that be a problem @theuni?

laanwj · 2016-08-12T13:00:29Z

Would it be possible to abstract out this functionality in a separate commit (including the existing RPC parsing logic from the Qt console) and move it to rpc/server.cpp,

Sorry to be contrary, but IMO, functionality related to parsing and not dispatching should be in rpc/client.cpp instead of rpc/server.cpp. Note that bitcoin-cli links the client library, not the server one.

(another reason that it doesn't belong server-side is that it doesn't act on univalue/JSON objects, but on command line strings. Wouldn't want string parsing on the server side, as this makes the JSON-RPC API unclear, and introduces potential vulnerabilities and DoS possibilities etc)

laanwj · 2016-08-12T13:06:34Z

src/Makefile.am

client.cpp is part of libbitcoin_cli, which is "cli: shared between bitcoin-cli and bitcoin-qt" if you need access to that then link that library. Don't include the compilation unit in two libraries.

jonasschnelli · 2016-08-12T13:08:38Z

Having it in rpc/client.cpp instead of server.cpp would be good I guess. The only restriction would then be, that we cannot allow (later) server side nested commands (which would probably perform slightly faster). But I'm not sure if we really want server side nested commands with the current locking behavior.

laanwj · 2016-08-12T13:12:41Z

Server-side nested commands are not part of the JSON-RPC standard. It is an interesting thought but that would be a completely different proposal, and I don't think it would share any code with this. I'd imagine it would work something akin to batching (but w/ nested structures), not by parsing/formatting expression strings. Seeing how little even simple batching is used, I'm also not sure there is enough demand for that kind of advanced behavior, but that aside.

Edit: Looked it up a bit, 'nested remote function call' in RPC protocols is commonly implemented in the form of 'promise pipelining', a strategy to reduce round-trips. A call can return a handle, which is essentially a temporary variable, which can be passed as argument to other calls before the result is known. This allows more versatile manipulation than just nesting (e.g. a DAG instead of a tree). In any case this is something to be found in the more advanced RPC frameworks, I couldn't find anyone having bolted it into JSON-RPC. As said, an issue for another time :)

Edit.2: Had a try at a proposal here: #8457 (comment)

theuni · 2016-08-12T18:07:30Z

Agreed with keeping parsing client-side. Let's not tangle up the dependencies.

I really like this idea btw.

jonasschnelli · 2016-08-20T09:21:55Z

Removed all changes from the core classes.
It's now a GUI only change.
Added Qt unit tests for the nested commands.

maflcko · 2016-08-21T12:02:10Z

qt-test fail on travis, apparently.

Commands can be executed with bracket syntax, example: `getwalletinfo()`. Commands can be nested, example: `sendtoaddress(getnewaddress(), 10)`. Simple queries are possible: `listunspent()[0][txid]` Object values are accessed with a non-quoted string, example: [txid]. Fully backward compatible. `generate 101` is identical to `generate(101)` Result value queries indicated with `[]` require the new brackets syntax. Comma as argument separator is now also possible: `sendtoaddress,<address>,<amount>` Space as argument separator works also with the bracket syntax, example: `sendtoaddress(getnewaddress() 10) No dept limitation, complex commands are possible: `decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]` Github-Pull: bitcoin#7783 Rebased-From: 1586044

c3055bb Add help-console command to Qt debug console (Luke Mlsna) Pull request description: This PR would close issue #9195 by adding documentation for the debug console features (mainly nested commands) which were added in [PR #7783](#7783). The following changes were made to QT debug console code: - Added a line to the initial message text at the top of the debug console: > For more information on using this console type **help-console**. - Added a pseudo-command `help-console` which is hooked after parsing the request, but before actually executing the RPC thread. It prints the following text to the console as if it were a valid RPC response. > This console accepts RPC commands using the standard syntax. > example: getblockhash 8 > This console can also accept RPC commands using bracketed syntax. > example: getblockhash(8) > A space or a comma can be used to separate arguments for either syntax. > example: sendtoaddress \<address\> \<amount\> > sendtoaddress,\<address\>,\<amount\> > Commands may be nested when specified with the bracketed syntax. > example: getblockinfo(getblockhash(0),true). > Result values can be queried with a non-quoted string in brackets. > example: getblock(getblockhash(0) true)[height] This seemed like a reasonably sane way to introduce a fake RPC help command, but Tree-SHA512: 35d73dcef9c4936b8be99e80978169f117c22b94f4400c91097bf7e0e1489060202dcd738d9debdf4c8a7bd10709e2c19d4f625f19e47c4a034f1d6019c0e0f2

…ple value queries 1586044 [Qt] RPC-Console: support nested commands and simple value queries (Jonas Schnelli)

f466c4c Add missing ECC_Stop(); in GUI rpcnestedtests.cpp (Jonas Schnelli) Pull request description: Fixes #16288 Was probably missing in #7783 ACKs for top commit: Sjors: ACK f466c4c. Tested by comparing `make check` on master and this PR with macOS 10.14.5. I also tried with and without `--enable-debug` / `--without-gui`. fanquake: ACK f466c4c. Tested running `make check` on macOS. Tree-SHA512: 648e10c2e35bd01fb92e63709169a6c185ac4b62c69af0109d2cd2d7db47e56ae804c788f9a1a1845746f818764799732f9e58e9dbfca3bffeea8f14683c8c7f

…ation c3055bb Add help-console command to Qt debug console (Luke Mlsna) Pull request description: This PR would close issue bitcoin#9195 by adding documentation for the debug console features (mainly nested commands) which were added in [PR bitcoin#7783](bitcoin#7783). The following changes were made to QT debug console code: - Added a line to the initial message text at the top of the debug console: > For more information on using this console type **help-console**. - Added a pseudo-command `help-console` which is hooked after parsing the request, but before actually executing the RPC thread. It prints the following text to the console as if it were a valid RPC response. > This console accepts RPC commands using the standard syntax. > example: getblockhash 8 > This console can also accept RPC commands using bracketed syntax. > example: getblockhash(8) > A space or a comma can be used to separate arguments for either syntax. > example: sendtoaddress \<address\> \<amount\> > sendtoaddress,\<address\>,\<amount\> > Commands may be nested when specified with the bracketed syntax. > example: getblockinfo(getblockhash(0),true). > Result values can be queried with a non-quoted string in brackets. > example: getblock(getblockhash(0) true)[height] This seemed like a reasonably sane way to introduce a fake RPC help command, but Tree-SHA512: 35d73dcef9c4936b8be99e80978169f117c22b94f4400c91097bf7e0e1489060202dcd738d9debdf4c8a7bd10709e2c19d4f625f19e47c4a034f1d6019c0e0f2

…ue queries 4fc2594 Build: Remove no-longer-needed Moc conflict workaround (Fuzzbawls) d763267 [Refactoring] Remove RPCExecutor code duplication between the 2 consoles (random-zebra) d4a9474 [Qt] RPC-Console: support nested commands and simple value queries (Jonas Schnelli) Pull request description: Backports a pretty cool feature for the GUI rpc-console from bitcoin#7783, which makes testing much faster, removing the need for copying/pasting the outputs of the commands. > Commands can be executed with bracket syntax, example: `getwalletinfo()`. > Commands can be nested, example: `sendtoaddress(getnewaddress(), 10)`. > Simple queries are possible: `listunspent()[0][txid]` > Object values are accessed with a non-quoted string, example: [txid]. > > Fully backward compatible. `generate 101` is identical to `generate(101)` > Result value queries indicated with `[]` require the new brackets syntax. > Comma as argument separator is now also possible: `sendtoaddress,<address>,<amount>` > Space as argument separator works also with the bracket syntax, example: `sendtoaddress(getnewaddress() 10) > > No dept limitation, complex commands are possible: > `decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]` <br> <img src="proxy.php?url=https://user-images.githubusercontent.com/18186894/113241705-8304e400-92af-11eb-9624-87921bb13f0a.png"> ACKs for top commit: Fuzzbawls: ACK 4fc2594 furszy: ACK 4fc2594 Tree-SHA512: 94258fec0b0100a728ded06690b6fd456a0cf5756ef68a5cb1eb73c96abf9b268d350058469c85cd5614ee1f3fa114218d362cb8f346a626fa4a3082424f81c6

c3055bb Add help-console command to Qt debug console (Luke Mlsna) Pull request description: This PR would close issue #9195 by adding documentation for the debug console features (mainly nested commands) which were added in [PR #7783](bitcoin/bitcoin#7783). The following changes were made to QT debug console code: - Added a line to the initial message text at the top of the debug console: > For more information on using this console type **help-console**. - Added a pseudo-command `help-console` which is hooked after parsing the request, but before actually executing the RPC thread. It prints the following text to the console as if it were a valid RPC response. > This console accepts RPC commands using the standard syntax. > example: getblockhash 8 > This console can also accept RPC commands using bracketed syntax. > example: getblockhash(8) > A space or a comma can be used to separate arguments for either syntax. > example: sendtoaddress \<address\> \<amount\> > sendtoaddress,\<address\>,\<amount\> > Commands may be nested when specified with the bracketed syntax. > example: getblockinfo(getblockhash(0),true). > Result values can be queried with a non-quoted string in brackets. > example: getblock(getblockhash(0) true)[height] This seemed like a reasonably sane way to introduce a fake RPC help command, but Tree-SHA512: 35d73dcef9c4936b8be99e80978169f117c22b94f4400c91097bf7e0e1489060202dcd738d9debdf4c8a7bd10709e2c19d4f625f19e47c4a034f1d6019c0e0f2

…ts.cpp f466c4c Add missing ECC_Stop(); in GUI rpcnestedtests.cpp (Jonas Schnelli) Pull request description: Fixes bitcoin#16288 Was probably missing in bitcoin#7783 ACKs for top commit: Sjors: ACK f466c4c. Tested by comparing `make check` on master and this PR with macOS 10.14.5. I also tried with and without `--enable-debug` / `--without-gui`. fanquake: ACK f466c4c. Tested running `make check` on macOS. Tree-SHA512: 648e10c2e35bd01fb92e63709169a6c185ac4b62c69af0109d2cd2d7db47e56ae804c788f9a1a1845746f818764799732f9e58e9dbfca3bffeea8f14683c8c7f

…ation c3055bb Add help-console command to Qt debug console (Luke Mlsna) Pull request description: This PR would close issue bitcoin#9195 by adding documentation for the debug console features (mainly nested commands) which were added in [PR bitcoin#7783](bitcoin#7783). The following changes were made to QT debug console code: - Added a line to the initial message text at the top of the debug console: > For more information on using this console type **help-console**. - Added a pseudo-command `help-console` which is hooked after parsing the request, but before actually executing the RPC thread. It prints the following text to the console as if it were a valid RPC response. > This console accepts RPC commands using the standard syntax. > example: getblockhash 8 > This console can also accept RPC commands using bracketed syntax. > example: getblockhash(8) > A space or a comma can be used to separate arguments for either syntax. > example: sendtoaddress \<address\> \<amount\> > sendtoaddress,\<address\>,\<amount\> > Commands may be nested when specified with the bracketed syntax. > example: getblockinfo(getblockhash(0),true). > Result values can be queried with a non-quoted string in brackets. > example: getblock(getblockhash(0) true)[height] This seemed like a reasonably sane way to introduce a fake RPC help command, but Tree-SHA512: 35d73dcef9c4936b8be99e80978169f117c22b94f4400c91097bf7e0e1489060202dcd738d9debdf4c8a7bd10709e2c19d4f625f19e47c4a034f1d6019c0e0f2

jonasschnelli added the GUI label Apr 1, 2016

jonasschnelli force-pushed the 2016/04/qt_console_nested branch 2 times, most recently from 7018480 to b5ba8fb Compare July 19, 2016 15:20

maflcko reviewed Jul 19, 2016
View reviewed changes

src/test/rpc_tests.cpp Outdated

Copy link

Member

maflcko Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no whitespace at the end?

jonasschnelli force-pushed the 2016/04/qt_console_nested branch from f05f9fd to 05a958e Compare July 20, 2016 13:26

laanwj reviewed Aug 12, 2016
View reviewed changes

laanwj mentioned this pull request Aug 13, 2016

Add block height support in rpc call getblock #8457

Closed

jonasschnelli force-pushed the 2016/04/qt_console_nested branch from 05a958e to 7a38506 Compare August 20, 2016 09:20

jonasschnelli force-pushed the 2016/04/qt_console_nested branch 3 times, most recently from 5f0e019 to 04a9485 Compare August 22, 2016 14:35

laanwj mentioned this pull request Nov 21, 2016

Debug console needs a little documentation on usage #9195

Closed

jonasschnelli mentioned this pull request Dec 12, 2016

sendmany no longer works over the GUI #9210

Closed

jonasschnelli mentioned this pull request Jan 10, 2017

TODO for release notes 0.14.0 #8455

Closed

18 tasks

This was referenced Nov 15, 2017

[Docs] [Qt] RPC-Console documentation lmlsna/bitcoin#1

Merged

[Docs] [Qt] RPC-Console nested commands documentation #11698

Merged

codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018

Merge bitcoin#7783: [Qt] RPC-Console: support nested commands and sim…

3872017

…ple value queries 1586044 [Qt] RPC-Console: support nested commands and simple value queries (Jonas Schnelli)

jonasschnelli mentioned this pull request Jun 26, 2019

test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp #16289

Merged

adamjonas mentioned this pull request Apr 29, 2020

Could not enter decoderawtransaction command equal or larger than 32KB in Bitcoin-Qt console window #7599

Closed

jonasschnelli mentioned this pull request Oct 30, 2020

Extend support for nested commands to bitcoin-cli #20273

Closed

random-zebra mentioned this pull request Apr 1, 2021

[GUI] RPC-Console support nested commands and simple value queries PIVX-Project/PIVX#2282

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Conversation

jonasschnelli commented Apr 1, 2016

Uh oh!

luke-jr commented Apr 1, 2016

Uh oh!

maflcko commented Apr 1, 2016

Uh oh!

jonasschnelli commented Apr 1, 2016

Uh oh!

laanwj commented Apr 2, 2016

Uh oh!

paveljanik commented Apr 2, 2016

Uh oh!

luke-jr commented Apr 2, 2016

Uh oh!

sipa commented Jun 2, 2016

Uh oh!

jonasschnelli commented Jun 2, 2016

Uh oh!

sipa commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UniQredit commented Jul 19, 2016

Uh oh!

jonasschnelli commented Jul 19, 2016

Uh oh!

maflcko Jul 19, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Jul 20, 2016

Uh oh!

laanwj commented Aug 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj Aug 12, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Aug 12, 2016

Uh oh!

laanwj commented Aug 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented Aug 12, 2016

Uh oh!

jonasschnelli commented Aug 20, 2016

Uh oh!

maflcko commented Aug 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

sipa commented Jun 2, 2016 •

edited

Loading

laanwj commented Aug 12, 2016 •

edited

Loading

laanwj commented Aug 12, 2016 •

edited

Loading