Use relative paths instead of absolute paths in protoc calls#7788
Merged
laanwj merged 1 commit intobitcoin:masterfrom Apr 5, 2016
Merged
Use relative paths instead of absolute paths in protoc calls#7788laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
Author
|
Travis failure is unrelated to this change. |
Member
|
I think this should be ok. I suspect it was absolute as part of the initial recursive buildsystem. Please make it |
paveljanik
force-pushed
the
20160402_protoc_use_relpath
branch
from
87fac00 to
0087f26
Compare
Contributor
Author
|
Done. Thanks. |
Contributor
Author
|
So after this, the remaining changes/diffs are for |
Member
|
Thanks. ACK. Don't think we can do anything about the configure subdirs, the |
Contributor
Author
|
@theuni yes, I can live with it and ignore such lines. |
Member
|
Nice, makes the line a few characters shorter too. utACK 0087f26 |
laanwj
added a commit
that referenced
this pull request
Apr 5, 2016
…alls 0087f26 Use relative paths instead of absolute paths (Pavel Janík)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
…rotoc calls 0087f26 Use relative paths instead of absolute paths (Pavel Janík)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing two separate build logs (both being done in its own, different directory), the log line containing
protocshines in the diff:There is no reason to use absolute paths here.
After this change, the
protoccommand line is always@theuni Please have a look.