Skip to content

[qa] Switch to py3#7814

Merged
laanwj merged 1 commit intobitcoin:masterfrom
maflcko:Mf1604-qaPy3
May 6, 2016
Merged

[qa] Switch to py3#7814
laanwj merged 1 commit intobitcoin:masterfrom
maflcko:Mf1604-qaPy3

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 5, 2016 •
edited
Loading

Blockers:

@laanwj laanwj added the Tests label Apr 5, 2016
@laanwj laanwj changed the title [qa] Switch to py3 [WIP] [qa] Switch to py3 Apr 6, 2016
@maflcko maflcko force-pushed the Mf1604-qaPy3 branch 12 times, most recently from f4f4881 to 8f2c4c2 Compare April 15, 2016 09:51
@maflcko maflcko force-pushed the Mf1604-qaPy3 branch 4 times, most recently from 7fd8792 to 606e83e Compare April 19, 2016 14:13
@maflcko maflcko mentioned this pull request Apr 20, 2016
Merged
@maflcko maflcko force-pushed the Mf1604-qaPy3 branch 7 times, most recently from 6004c6f to 4fe25f8 Compare April 27, 2016 10:24
@maflcko maflcko changed the title [WIP] [qa] Switch to py3 [qa] Switch to py3 Apr 27, 2016
@maflcko maflcko changed the title [qa] Switch to py3 [WIP] [qa] Switch to py3 Apr 27, 2016
@laanwj laanwj mentioned this pull request Apr 28, 2016
Closed
16 tasks
@laanwj
Copy link
Member

laanwj commented May 5, 2016

Ah yes - merging a pull that adds a new test wasn't a very good idea. Now this probably needs to be updated to include the new test, otherwise it can't be merged without breaking travis.

@maflcko maflcko force-pushed the Mf1604-qaPy3 branch 2 times, most recently from f941db8 to faa68c8 Compare May 5, 2016 13:41
@maflcko
Copy link
Member Author

maflcko commented May 5, 2016

JSONRPC error: Method not found

Na, you just need to compile the new signmessage code.

Rebased nonetheless.

@maflcko
Copy link
Member Author

maflcko commented May 5, 2016

Interesting that this makes the test slower, though:

py3:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testgxs02bu5
Stopping nodes
Cleaning up
Tests successful
Duration: 2 s

py2:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testXaAvpQ
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

wait_bitcoinds() takes 2 seconds now.

@laanwj
Copy link
Member

laanwj commented May 5, 2016

Strange.

@maflcko
Copy link
Member Author

maflcko commented May 6, 2016

Indeed interesting; Other test still run fast with py3:

$ qa/pull-tester/rpc-tests.py disablewallet
Running testscript disablewallet.py ...
Initializing test directory /tmp/test_zgnh7e3
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

But let's not worry about it too much, this will be compensated by #7972, hopefully.

@laanwj
Copy link
Member

laanwj commented May 6, 2016

Right, well if it is two seconds on one test I don't see why it would need to be a blocker.

@laanwj laanwj merged commit fa389d4 into bitcoin:master May 6, 2016
laanwj added a commit that referenced this pull request May 6, 2016
@laanwj
Merge #7814: [qa] Switch to py3
77b637f 
fa389d4 [qa] Switch to py3 (MarcoFalke)
@maflcko maflcko deleted the Mf1604-qaPy3 branch May 6, 2016 09:25
@maflcko maflcko mentioned this pull request Jun 9, 2016
Merged
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jul 15, 2016
[qa] Switch to py3
2826565 
Github-Pull: bitcoin#7814
Rebased-From: fa389d4
@dagurval dagurval mentioned this pull request Aug 29, 2017
Merged
@OlegGirko OlegGirko mentioned this pull request Nov 3, 2017
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Dec 21, 2017
@laanwj @codablock
Merge bitcoin#7814: [qa] Switch to py3
25147c9 
fa389d4 [qa] Switch to py3 (MarcoFalke)
@Eirik0 Eirik0 mentioned this pull request Oct 31, 2018
Merged
@str4d str4d mentioned this pull request Nov 19, 2020
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Dec 2, 2020
@zkbot
Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
7a0a268 
Backport migration from rpc-tests.sh to rpc-tests.py

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6567
- bitcoin/bitcoin#6523
- bitcoin/bitcoin#6616
- bitcoin/bitcoin#6788
  - Only the commit fixing `rpc-tests.py`
- bitcoin/bitcoin#6791
  - Only the fix to `qa/rpc-tests/README.md`
- bitcoin/bitcoin#6827
- bitcoin/bitcoin#6930
- bitcoin/bitcoin#6804
- bitcoin/bitcoin#7029
- bitcoin/bitcoin#7028
- bitcoin/bitcoin#7027
- bitcoin/bitcoin#7135
- bitcoin/bitcoin#7209
- bitcoin/bitcoin#7635
- bitcoin/bitcoin#7778
- bitcoin/bitcoin#7851
- bitcoin/bitcoin#7814
  - Only the changes to the new .py files in this PR.
- bitcoin/bitcoin#7971
- bitcoin/bitcoin#7972
- bitcoin/bitcoin#8056
  - Only the first commit.
- bitcoin/bitcoin#8098
- bitcoin/bitcoin#8104
- bitcoin/bitcoin#8133
  - Only the `rpc-tests.py` commit.
- bitcoin/bitcoin#8066
- bitcoin/bitcoin#8216
  - Only the last two commits.
- bitcoin/bitcoin#8254
- bitcoin/bitcoin#8400
- bitcoin/bitcoin#8482
  - Excluding the first commit (only affects RPC tests we don't have).
- bitcoin/bitcoin#8551
- bitcoin/bitcoin#8607
  - Only the pull-tester commit, for conflict removal.
- bitcoin/bitcoin#8625
- bitcoin/bitcoin#8713
- bitcoin/bitcoin#8750
- bitcoin/bitcoin#8789
- bitcoin/bitcoin#9098
- bitcoin/bitcoin#9276
  - Excluding the second commit (we don't have the changes it requires).
- bitcoin/bitcoin#9657
- bitcoin/bitcoin#9807
- bitcoin/bitcoin#9766
- bitcoin/bitcoin#9823
zkbot added a commit to zcash/zcash that referenced this pull request Dec 2, 2020
@zkbot
Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
c8896f9 
Backport migration from rpc-tests.sh to rpc-tests.py

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6567
- bitcoin/bitcoin#6523
- bitcoin/bitcoin#6616
- bitcoin/bitcoin#6788
  - Only the commit fixing `rpc-tests.py`
- bitcoin/bitcoin#6791
  - Only the fix to `qa/rpc-tests/README.md`
- bitcoin/bitcoin#6827
- bitcoin/bitcoin#6930
- bitcoin/bitcoin#6804
- bitcoin/bitcoin#7029
- bitcoin/bitcoin#7028
- bitcoin/bitcoin#7027
- bitcoin/bitcoin#7135
- bitcoin/bitcoin#7209
- bitcoin/bitcoin#7635
- bitcoin/bitcoin#7778
- bitcoin/bitcoin#7851
- bitcoin/bitcoin#7814
  - Only the changes to the new .py files in this PR.
- bitcoin/bitcoin#7971
- bitcoin/bitcoin#7972
- bitcoin/bitcoin#8056
  - Only the first commit.
- bitcoin/bitcoin#8098
- bitcoin/bitcoin#8104
- bitcoin/bitcoin#8133
  - Only the `rpc-tests.py` commit.
- bitcoin/bitcoin#8066
- bitcoin/bitcoin#8216
  - Only the last two commits.
- bitcoin/bitcoin#8254
- bitcoin/bitcoin#8400
- bitcoin/bitcoin#8482
  - Excluding the first commit (only affects RPC tests we don't have).
- bitcoin/bitcoin#8551
- bitcoin/bitcoin#8607
  - Only the pull-tester commit, for conflict removal.
- bitcoin/bitcoin#8625
- bitcoin/bitcoin#8713
- bitcoin/bitcoin#8750
- bitcoin/bitcoin#8789
- bitcoin/bitcoin#9098
- bitcoin/bitcoin#9276
  - Excluding the second commit (we don't have the changes it requires).
- bitcoin/bitcoin#9657
- bitcoin/bitcoin#9807
- bitcoin/bitcoin#9766
- bitcoin/bitcoin#9823
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maflcko @laanwj @fanquake