[Wallet] Add cloned wallet, remove accounts, reset version#7830
Closed
jonasschnelli wants to merge 7 commits intobitcoin:masterfrom
Closed
[Wallet] Add cloned wallet, remove accounts, reset version#7830jonasschnelli wants to merge 7 commits intobitcoin:masterfrom
jonasschnelli wants to merge 7 commits intobitcoin:masterfrom
Conversation
jonasschnelli
force-pushed
the
2016/04/wallet2
branch
from
ba9f417 to
2fbbe96
Compare
Member
|
s/save/safe |
jonasschnelli
force-pushed
the
2016/04/wallet2
branch
from
2fbbe96 to
5a36731
Compare
|
Finally!!!! Great to see it's finally happening. |
Member
|
Instead of copying several thousand lines of code, wouldn't it be possible to avoid that by leaving the current wallet implementation as a base class and then create a derived classes CLegacyWallet() and CLightWallet()? I haven't looked closely at the code, so I don't know if it is feasible, but it's a thought. |
| static HTTPRPCTimerInterface* httpRPCTimerInterface = 0; | ||
|
|
||
| static void JSONErrorReply(HTTPRequest* req, const UniValue& objError, const UniValue& id) | ||
| void JSONErrorReply(HTTPRequest* req, const UniValue& objError, const UniValue& id) |
Member
There was a problem hiding this comment.
Why make this non-static? You're not ever using this outside httprpc (same for RPCAuthorized and HTTPReq_HandleAuth)
Contributor
Author
|
Closing for now. Not sure if this is the best solution. Needs discussion on the bitcoin-core-dev mailing list first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative solution to #7729
This adds a clone of the current wallet. The second wallet can be enabled over
--enable-lightwallet.Includes:
Lightwallet::.CAccount,CAccountEntry, etc.).sandmanynow renamed to "sendcoins")10000Benefits:
Currently bitcoin-cli misses some value conversion for some commands (you can use cURL for these commands).
This PR is large because of the copy of the content in
src/wallet. You can verify the copy by diffing the first commit and start review on top of that**