Skip to content

[qa] pull-tester: Don't mute zmq ImportError#7851

Merged
laanwj merged 3 commits intobitcoin:masterfrom
maflcko:Mf1604-qaUnmuteError
Apr 19, 2016
Merged

[qa] pull-tester: Don't mute zmq ImportError#7851
laanwj merged 3 commits intobitcoin:masterfrom
maflcko:Mf1604-qaUnmuteError

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 9, 2016

Let's consider muting exceptions bad practice. It is good to have a more verbose output, so I left this as is.

@maflcko maflcko force-pushed the Mf1604-qaUnmuteError branch from fa70a24 to fa2a0d5 Compare April 9, 2016 20:34
@maflcko maflcko force-pushed the Mf1604-qaUnmuteError branch from fa2a0d5 to faa4f22 Compare April 9, 2016 21:08
@maflcko
Copy link
Member Author

maflcko commented Apr 9, 2016

Looks like I need to move some code; use faa4f22?w=0 to check the second diff.

@laanwj laanwj added the Tests label Apr 11, 2016
laanwj
laanwj reviewed Apr 14, 2016
View reviewed changes
qa/pull-tester/rpc-tests.py
#Disable Windows tests by default
if EXEEXT == ".exe" and "-win" not in opts:
print "Win tests currently disabled. Use -win option to enable"
# https://github.com/bitcoin/bitcoin/commit/d52802551752140cf41f0d9a225a43e84404d3e9
Copy link
Member

@laanwj laanwj Apr 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to refer to the discussion of the pull this was part of: #5677 (comment)

Copy link
Member Author

@maflcko maflcko Apr 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@laanwj
Copy link
Member

laanwj commented Apr 14, 2016

Concept ACK

@maflcko maflcko mentioned this pull request Apr 16, 2016
Merged
1 task
laanwj
laanwj reviewed Apr 18, 2016
View reviewed changes
qa/pull-tester/rpc-tests.py Outdated
Copy link
Member

@laanwj laanwj Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer a WARNING but an ERROR now

Copy link
Member Author

@maflcko maflcko Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@maflcko maflcko force-pushed the Mf1604-qaUnmuteError branch from fa2c9ca to fae1f4e Compare April 18, 2016 12:52
@laanwj laanwj merged commit fae1f4e into bitcoin:master Apr 19, 2016
laanwj added a commit that referenced this pull request Apr 19, 2016
@laanwj
Merge #7851: [qa] pull-tester: Don't mute zmq ImportError
fa9d86f 
fae1f4e [qa] rpc-tests: Fix link in comment and label error msg (MarcoFalke)
faa4f22 [qa] pull-tester: Exit early when no tests are run (MarcoFalke)
fa05e22 [qa] pull-tester: Don't mute zmq ImportError (MarcoFalke)
@maflcko maflcko deleted the Mf1604-qaUnmuteError branch April 19, 2016 09:26
@maflcko maflcko mentioned this pull request May 7, 2016
Merged
laanwj added a commit to laanwj/bitcoin that referenced this pull request May 9, 2016
@laanwj
test: Revert fatal-ness of missing python-zmq
65fee8e 
It looks like travis is using the `travis.yml` from the branch, but runs
the test script from the branch merged into master. This causes
pull requests created before the QA tests python 3 transition to fail.

This temporarily reverts fa05e22
(bitcoin#7851). It can be restored when this is no longer an issue.
@laanwj laanwj mentioned this pull request May 9, 2016
Merged
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jun 9, 2016
[qa] pull-tester: Don't mute zmq ImportError
e0b1bbe 
Github-Pull: bitcoin#7851
Rebased-From: fa05e22 faa4f22 fae1f4e
@dagurval dagurval mentioned this pull request Sep 3, 2017
Merged
@str4d str4d mentioned this pull request Nov 19, 2020
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Dec 2, 2020
@zkbot
Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
7a0a268 
Backport migration from rpc-tests.sh to rpc-tests.py

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6567
- bitcoin/bitcoin#6523
- bitcoin/bitcoin#6616
- bitcoin/bitcoin#6788
  - Only the commit fixing `rpc-tests.py`
- bitcoin/bitcoin#6791
  - Only the fix to `qa/rpc-tests/README.md`
- bitcoin/bitcoin#6827
- bitcoin/bitcoin#6930
- bitcoin/bitcoin#6804
- bitcoin/bitcoin#7029
- bitcoin/bitcoin#7028
- bitcoin/bitcoin#7027
- bitcoin/bitcoin#7135
- bitcoin/bitcoin#7209
- bitcoin/bitcoin#7635
- bitcoin/bitcoin#7778
- bitcoin/bitcoin#7851
- bitcoin/bitcoin#7814
  - Only the changes to the new .py files in this PR.
- bitcoin/bitcoin#7971
- bitcoin/bitcoin#7972
- bitcoin/bitcoin#8056
  - Only the first commit.
- bitcoin/bitcoin#8098
- bitcoin/bitcoin#8104
- bitcoin/bitcoin#8133
  - Only the `rpc-tests.py` commit.
- bitcoin/bitcoin#8066
- bitcoin/bitcoin#8216
  - Only the last two commits.
- bitcoin/bitcoin#8254
- bitcoin/bitcoin#8400
- bitcoin/bitcoin#8482
  - Excluding the first commit (only affects RPC tests we don't have).
- bitcoin/bitcoin#8551
- bitcoin/bitcoin#8607
  - Only the pull-tester commit, for conflict removal.
- bitcoin/bitcoin#8625
- bitcoin/bitcoin#8713
- bitcoin/bitcoin#8750
- bitcoin/bitcoin#8789
- bitcoin/bitcoin#9098
- bitcoin/bitcoin#9276
  - Excluding the second commit (we don't have the changes it requires).
- bitcoin/bitcoin#9657
- bitcoin/bitcoin#9807
- bitcoin/bitcoin#9766
- bitcoin/bitcoin#9823
zkbot added a commit to zcash/zcash that referenced this pull request Dec 2, 2020
@zkbot
Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
c8896f9 
Backport migration from rpc-tests.sh to rpc-tests.py

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6567
- bitcoin/bitcoin#6523
- bitcoin/bitcoin#6616
- bitcoin/bitcoin#6788
  - Only the commit fixing `rpc-tests.py`
- bitcoin/bitcoin#6791
  - Only the fix to `qa/rpc-tests/README.md`
- bitcoin/bitcoin#6827
- bitcoin/bitcoin#6930
- bitcoin/bitcoin#6804
- bitcoin/bitcoin#7029
- bitcoin/bitcoin#7028
- bitcoin/bitcoin#7027
- bitcoin/bitcoin#7135
- bitcoin/bitcoin#7209
- bitcoin/bitcoin#7635
- bitcoin/bitcoin#7778
- bitcoin/bitcoin#7851
- bitcoin/bitcoin#7814
  - Only the changes to the new .py files in this PR.
- bitcoin/bitcoin#7971
- bitcoin/bitcoin#7972
- bitcoin/bitcoin#8056
  - Only the first commit.
- bitcoin/bitcoin#8098
- bitcoin/bitcoin#8104
- bitcoin/bitcoin#8133
  - Only the `rpc-tests.py` commit.
- bitcoin/bitcoin#8066
- bitcoin/bitcoin#8216
  - Only the last two commits.
- bitcoin/bitcoin#8254
- bitcoin/bitcoin#8400
- bitcoin/bitcoin#8482
  - Excluding the first commit (only affects RPC tests we don't have).
- bitcoin/bitcoin#8551
- bitcoin/bitcoin#8607
  - Only the pull-tester commit, for conflict removal.
- bitcoin/bitcoin#8625
- bitcoin/bitcoin#8713
- bitcoin/bitcoin#8750
- bitcoin/bitcoin#8789
- bitcoin/bitcoin#9098
- bitcoin/bitcoin#9276
  - Excluding the second commit (we don't have the changes it requires).
- bitcoin/bitcoin#9657
- bitcoin/bitcoin#9807
- bitcoin/bitcoin#9766
- bitcoin/bitcoin#9823
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maflcko @laanwj