bitcoin-cli.cpp: Use symbolic constant for exit code#7989
Merged
laanwj merged 1 commit intobitcoin:masterfrom May 4, 2016
tuladhar:patch-2
Merged
bitcoin-cli.cpp: Use symbolic constant for exit code#7989laanwj merged 1 commit intobitcoin:masterfrom tuladhar:patch-2
laanwj merged 1 commit intobitcoin:masterfrom
tuladhar:patch-2
Conversation
Contributor
|
Looks much better, ACK 9a8a7d0 No need to open new PR next time :-) |
Member
|
Trivially correct ACK 9a8a7d0 |
laanwj
added a commit
that referenced
this pull request
May 4, 2016
9a8a7d0 bitcoin-cli.cpp: Use symbolic constant for exit code (Puru)
Member
|
I think the motivation for this change was https://stackoverflow.com/questions/461449/return-statement-vs-exit-in-main , so the commit message would be still "wrong". But the code looks good. utACK 9a8a7d0 |
Member
|
It's no less wrong or right, IMO, but it harmonizes the function a bit - all of the other exits from main() use return EXIT_FAILURE. |
Contributor
Author
|
@laanwj Thanks for the merge! |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 13, 2018
CLI binary improvements Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5936 - bitcoin/bitcoin#7550 - bitcoin/bitcoin#7989 - bitcoin/bitcoin#7957 - bitcoin/bitcoin#9067 - bitcoin/bitcoin#9220 Excludes any changes that affected the QT code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.