[depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat by fanquake · Pull Request #7993 · bitcoin/bitcoin

fanquake · 2016-05-03T12:57:36Z

miniupnpc 2.0 changelog
expat 2.1.1 changelog
freetype 2.6.3, changelog, change download url to the mirror at gnu.org
ccache 3.2.5 changelog
zeromq 4.1.4 changelog
Latest config.guess & config.sub

theuni · 2016-05-03T22:53:18Z

adding "--without-libsodium" should fix the zmq build, by the looks

fanquake · 2016-05-10T04:01:28Z

Rebased onto master, and should have fixed the ZeroMQ build issues (needed --without-libsodium and no longer need to look in the src dir)

fanquake · 2016-05-12T12:55:53Z

Added two additional commits updating miniupnpc and expat
Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

miniupnpc changelog

laanwj · 2016-05-20T10:09:46Z

utACK

Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

Oh! I see expat is used indirectly through dbus. Already wondered what we were using a XML parsing library for.
Wonder if any of that code ends up in the executable or it's just used for dbus' build tools.

sipa · 2016-06-01T18:59:27Z

Concept ACK. I haven't checked the hashes.

theuni · 2016-06-01T20:20:39Z

depends/packages/zeromq.mk

Please use:
$(MAKE) libzmq.la to avoid building stuff other than the lib

theuni · 2016-06-01T20:27:35Z

@laanwj Yes, through dbus and fontconfig. Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Still need it for fontconfig though :(

theuni · 2016-06-01T20:28:04Z

utACK, with the exception of the two nits.

Update FreeType, and change the download location to gnu.org. This is the other official download location listed on freetype.org

fanquake · 2016-06-02T01:45:31Z

Nits addressed, and rebased on master

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

laanwj · 2016-06-08T12:23:16Z

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

No urgency in bumping. But removal that should be discussed separately. We do use dbus for the notification stuff in the Qt GUI, so there are (minor) consequences for users.

laanwj · 2016-06-08T12:24:04Z

Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Oh I missed that part. Yes makes sense to remove it then.

laanwj · 2016-06-08T12:25:36Z

utACK 6a4cf16

6a4cf16 [depends] expat 2.1.1 (fanquake) 3e0587b [depends] miniupnpc 2.0 (fanquake) 87b8175 [depends] Latest config.guess & config.sub (fanquake) bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake) 0385202 [depends] ccache 3.2.5 (fanquake) 2b2d52e [depends] Freetype 2.6.3 (fanquake)

Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.

…c, expat 6a4cf16 [depends] expat 2.1.1 (fanquake) 3e0587b [depends] miniupnpc 2.0 (fanquake) 87b8175 [depends] Latest config.guess & config.sub (fanquake) bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake) 0385202 [depends] ccache 3.2.5 (fanquake) 2b2d52e [depends] Freetype 2.6.3 (fanquake)

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](#7993 (comment)) and [here](#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since bitcoin#8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin#7993 (comment)) and [here](bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of bitcoin#16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin/bitcoin#7993 (comment)) and [here](bitcoin/bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

fanquake force-pushed the depends-no-sourceforge branch from dad4449 to 2b9361b Compare May 4, 2016 01:37

fanquake mentioned this pull request May 4, 2016

[depends] Boost fails to build on OSX 10.11, Xcode 7.3.1 #7998

Closed

maflcko added the Build system label May 4, 2016

fanquake force-pushed the depends-no-sourceforge branch 4 times, most recently from 0074ea1 to 6696665 Compare May 10, 2016 03:56

fanquake force-pushed the depends-no-sourceforge branch 2 times, most recently from 843ad16 to ad4a9f3 Compare May 18, 2016 13:17

fanquake changed the title ~~[depends] Update FreeType, ccache, ZeroMQ~~ [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat May 21, 2016

theuni reviewed Jun 1, 2016
View reviewed changes

depends/packages/zeromq.mk Outdated

Copy link

Member

theuni Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use:
$(MAKE) libzmq.la to avoid building stuff other than the lib

fanquake added 6 commits June 2, 2016 09:16

[depends] Freetype 2.6.3

2b2d52e

Update FreeType, and change the download location to gnu.org. This is the other official download location listed on freetype.org

[depends] ccache 3.2.5

0385202

[depends] ZeroMQ 4.1.4

bd3cbd5

[depends] Latest config.guess & config.sub

87b8175

[depends] miniupnpc 2.0

3e0587b

[depends] expat 2.1.1

6a4cf16

fanquake mentioned this pull request Jun 2, 2016

[WIP] [depends] Qt 5.6.1 #8053

Closed

1 task

fanquake force-pushed the depends-no-sourceforge branch from ad4a9f3 to 6a4cf16 Compare June 2, 2016 01:36

laanwj merged commit 6a4cf16 into bitcoin:master Jun 8, 2016

fanquake mentioned this pull request Jun 17, 2016

[Qt] Bump to Qt5.6.1 #8210

Merged

fanquake deleted the depends-no-sourceforge branch June 22, 2016 08:38

str4d mentioned this pull request Jan 31, 2017

Add ZeroMQ notifications zcash/zcash#2050

Merged

schinzelh mentioned this pull request Oct 19, 2017

[WIP] Update build system to Bitcoin 0.13.2 dashpay/dash#1692

Closed

24 tasks

fanquake mentioned this pull request Jul 7, 2019

build: prune dbus from depends #16352

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat#7993

[depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat#7993
laanwj merged 6 commits intobitcoin:masterfrom
fanquake:depends-no-sourceforge

fanquake commented May 3, 2016 •

edited

Loading

Uh oh!

theuni commented May 3, 2016

Uh oh!

fanquake commented May 10, 2016

Uh oh!

fanquake commented May 12, 2016

Uh oh!

laanwj commented May 20, 2016

Uh oh!

sipa commented Jun 1, 2016

Uh oh!

theuni Jun 1, 2016

Uh oh!

theuni commented Jun 1, 2016

Uh oh!

theuni commented Jun 1, 2016

Uh oh!

fanquake commented Jun 2, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fanquake commented May 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented May 3, 2016

Uh oh!

fanquake commented May 10, 2016

Uh oh!

fanquake commented May 12, 2016

Uh oh!

laanwj commented May 20, 2016

Uh oh!

sipa commented Jun 1, 2016

Uh oh!

theuni Jun 1, 2016

Choose a reason for hiding this comment

Uh oh!

theuni commented Jun 1, 2016

Uh oh!

theuni commented Jun 1, 2016

Uh oh!

fanquake commented Jun 2, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

laanwj commented Jun 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fanquake commented May 3, 2016 •

edited

Loading