Add a comment indicating that the btc devs don't want a warning fixed#8005
Add a comment indicating that the btc devs don't want a warning fixed#8005avar wants to merge 1 commit intobitcoin:masterfrom
Conversation
The src/test/scheduler_tests.cpp test has been disabled since
v0.9.0rc2-4332-g8f0d79e, since then it's been warning about the
MicroSleep() function being unused, e.g. on GCC 4.9.2-10:
test/scheduler_tests.cpp:32:13: warning: ‘void
scheduler_tests::MicroSleep(uint64_t)’ defined but not used
[-Wunused-function]
The bitcoin developers don't want this warning fixed, and are instead
using it as a reminder to fix the test. Since this is a rather
unorthodox use of compiler warnings add a comment about this so people
who build bitcoin and notice compiler warnings don't try to submit
patches for this one.
See bitcoin#8003 and
bitcoin#7169 for past attempts to fix
this warning which have been rejected.
|
I'd rather have the test fixed, or replaced by a test without the race condition. But given no one is doing that at the moment, this warning is fine with me. |
|
@laanwj Yes it's clear from the various refused pull requests that you want the test fixed and want to keep this warning. This pull request is not orthogonal to that, but is rather for noting that this "compiler warning as a reminder" shouldn't be fixed. |
|
I agree. |
|
No longer necessary after #8016, which fixes the underlying issue. |
3 participants
The src/test/scheduler_tests.cpp test has been disabled since
v0.9.0rc2-4332-g8f0d79e, since then it's been warning about the
MicroSleep() function being unused, e.g. on GCC 4.9.2-10:
The bitcoin developers don't want this warning fixed, and are instead
using it as a reminder to fix the test. Since this is a rather
unorthodox use of compiler warnings add a comment about this so people
who build bitcoin and notice compiler warnings don't try to submit
patches for this one.
See #8003 and
#7169 for past attempts to fix
this warning which have been rejected.