Consensus: Decouple from chainparams.o and timedata.o#8077
Merged
sipa merged 1 commit intobitcoin:masterfrom Jun 1, 2016
Merged
Consensus: Decouple from chainparams.o and timedata.o#8077sipa merged 1 commit intobitcoin:masterfrom
sipa merged 1 commit intobitcoin:masterfrom
Conversation
Do it for the consensus-critical functions: - CheckBlockHeader - CheckBlock - ContextualCheckBlockHeader
jtimon
force-pushed
the
0.12-consensus-chainparams
branch
from
9c633e1 to
ee9f4a5
Compare
Contributor
|
utACK ee9f4a5 |
Member
|
ut/Concept ACK ee9f4a5 |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
utACK |
sipa
added a commit
that referenced
this pull request
Jun 1, 2016
ee9f4a5 Consensus: Decouple from chainparams.o and timedata.o (Jorge Timón)
Closed
15 tasks
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
…ta.o ee9f4a5 Consensus: Decouple from chainparams.o and timedata.o (Jorge Timón)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…ta.o ee9f4a5 Consensus: Decouple from chainparams.o and timedata.o (Jorge Timón)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do it for the consensus-critical functions:
Part of #7829. Competing with #7985 and #7947.
Rationale: if these functions are to be moved to the consensus module/package, they need to stop depending on chainparams.o and timedata.o from the server package.
Somewhat analogous to #7459.