Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.#817
Merged
gmaxwell merged 1 commit intobitcoin:masterfrom Feb 11, 2012
Merged
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.#817gmaxwell merged 1 commit intobitcoin:masterfrom
gmaxwell merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
Author
|
0.5.X version: TheBlueMatt@a910838 |
This fixes a potential bug where some NATs may replace the node's interal IP with its external IP in version messages, causing incorrect checksums when version messages begin being checksummed on February 14, 2012.
Contributor
|
This is a good idea regardless of the NAT issue. There is no reason to leak internal non-routable addresses in version messages, and that part of the patch is clearly safe because using a proxy has the same effect (also because we don't actually do anything with that data). Using UPNP to get our external IP is also a good idea. The current dependance on centralized address identifying services is a bad one. |
Contributor
|
ACK |
1 similar comment
Member
|
ACK |
Contributor
|
ACK, took me a while to setup upnp to test this. |
gmaxwell
added a commit
that referenced
this pull request
Feb 11, 2012
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
- Terrible bug which caused governance objects to have their hashes corrupted, causing objects to become invalid - More proposal -> governance name changes
ptschip
added a commit
to ptschip/bitcoin
that referenced
this pull request
Dec 19, 2017
* Uncache any valid coins when trimming the orphan cache * Only remove coins from the coins cache if they failed to enter the mempool However, do not remove them if the txn was an Orphan. We need to keep orphaned coins until and unless those orphans get trimmed from the orphan cache. * Update log message when checkinputs fails for a tx * fMissingInputs must be defined when calling AcceptToMemoryPool * Add UncacheTx() to Coins.cpp and use it * UnCache coins when txns are expired from the mempool * Add more detailed explanation about how vCoinsToUncache works. It's not entirely intuitive as to why the tracking happens at this point in AcceptToMemoryPoolWorker(). * Remove unnecessary if(pfMissingInputs) This clarifies the intent of the code. If we're missing inputs then this is an orphan and we don't want to uncache the coins. * Make sure to cache all coins in an orphan Some orphans may have valid inputs and one or more missing inputs. Make sure to get the valid ones into cache before returning from AcceptToMemoryPoolWorker(). * Add tests for uncaching coins Disable mocktime at end of test move txvalidationcache_tests.cpp to the original place in the Makefile Make nLastOrphanCheck and extern and use it When we use EraseOrphanByTime() in the test suite we must set the nLastOrphanCheck time also otherwise tests that run earlier can impact tests that run afterward resulting in orphans that do not get erased when they should be. * Handle pfMissingInputs if passed as a NULL. * formatting * change where *pfMissingIputs is set to false
Losangelosgenetics
pushed a commit
to Losangelosgenetics/bitcoin
that referenced
this pull request
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a potential bug where some NATs may replace the node's
interal IP with its external IP in version messages, causing
incorrect checksums when version messages begin being checksummed
on February 14, 2012.