[RPC] Fix createrawtx sequence number unsigned int parsing#8171
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 16, 2016
Merged
[RPC] Fix createrawtx sequence number unsigned int parsing#8171laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
utACK 6fa950a (but the added tests are sufficient) |
Contributor
|
ACK 6fa950a |
Contributor
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jun 16, 2016
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
…t parsing 6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
May 4, 2018
…quence number bitcoin/bitcoin#7957 - [RPC][Bitcoin-TX] Add support for sequence number bitcoin/bitcoin#8164 - [Bitcoin-Tx] fix missing test fixtures, fix 32bit atoi issue bitcoin/bitcoin#8171 - [RPC] Fix createrawtx sequence number unsigned int parsing [RPC][Bitcoin-TX] Add support for sequence number
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
May 9, 2018
…quence number bitcoin/bitcoin#7957 - [RPC][Bitcoin-TX] Add support for sequence number bitcoin/bitcoin#8164 - [Bitcoin-Tx] fix missing test fixtures, fix 32bit atoi issue bitcoin/bitcoin#8171 - [RPC] Fix createrawtx sequence number unsigned int parsing [RPC][Bitcoin-TX] Add support for sequence number
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…t parsing 6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another cleanup PR for #7957.
The sequence number input over RPC was parsed with ParseInt32 and inputs > 0x7FFFFFFF where rejected.
This PR reads inputs with get_int64 and does a range check (>=0 <= 0xFFFFFFFF).