Do not set extra flags for unfiltered DNS seed results#8208
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 16, 2016
Merged
Do not set extra flags for unfiltered DNS seed results#8208laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
utACK |
Contributor
|
Thanks for fixing. |
Member
|
utACK bc0a895 |
laanwj
added a commit
that referenced
this pull request
Jun 16, 2016
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
…sults bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…sults bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)
21 tasks
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
May 14, 2020
…ults 9107379 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille) Pull request description: Backport of bitcoin#8208 based on top of #1616 (Only the last commit is important here). Part of #1374. Original Description: > Any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering. > > Fix this by making the name adaptation function also update the passed in flags. > > Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only. ACKs for top commit: random-zebra: utACK 9107379 furszy: utACK 9107379 Tree-SHA512: a4c75fcdabac7afbd5df4b33f0bd02a438dffa75b8b63bc49fe63998579c8a15d6067cc357a72efd0b8123c9708853b9e2d04eada7ae85c088b0952bcf0baa90
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #8083 and #7749 were both merged, any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering.
Fix this by making the name adaptation function also update the passed in flags.
Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only.