Showing "not_applicable" if BIP9 timeout is 0#8209
Closed
jl2012 wants to merge 1 commit intobitcoin:masterfrom
Closed
Showing "not_applicable" if BIP9 timeout is 0#8209jl2012 wants to merge 1 commit intobitcoin:masterfrom
jl2012 wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
This new logic seems "out there" to the reader. You may want to document the reasoning for this check. |
Contributor
Author
|
Comments added |
| " \"bip9_softforks\": { (object) status of BIP9 softforks in progress\n" | ||
| " \"xxxx\" : { (string) name of the softfork\n" | ||
| " \"status\": \"xxxx\", (string) one of \"defined\", \"started\", \"lockedin\", \"active\", \"failed\"\n" | ||
| " \"status\": \"xxxx\", (string) one of \"defined\", \"started\", \"locked_in\", \"active\", \"failed\", \"not_applicable\"\n" |
Contributor
|
So when such a softfork is merged in, what is its state (according to BIP9)? |
Member
|
I think we should just hide deployments whose end time is 0. For all
intents and purposes, the software behaves as if the deployment didn't
exist at all.
|
Contributor
Author
|
replaced by #8258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getblockchaininfo will show a BIP9 proposal as "not_applicable" (instead of "failed") if the timeout is 0. A timeout before the genesis block timestamp guaruntees that a softfork must not be activated in any circumstances. A timeout of 0 should be used when we want to merge a softfork proposal without defining its deployment schedule