Stop trimming when mapTx is empty#8220
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 20, 2016
Merged
Conversation
Contributor
|
@sipa ie sizelimit < overhead of zero transactions ? |
Member
Author
|
@pstratem Yes, given that there are various support data structures in the mempool whose size is hard to scale linearly with the number of transactions, this seems like a reasonable solution. There are certainly others (like requiring the trim size to be at least a multiple of a transaction + overhead), but this is so simple and probably something that should have been there as a safeguard from the start. |
Contributor
|
utACK. |
Contributor
|
utACK ad0752e |
Contributor
|
utACK ad0752e |
Contributor
|
ACK ad0752e |
Merged
Contributor
|
utACK ad0752e |
Contributor
|
ACK ad0752e (upgrade from prior utack) |
laanwj
added a commit
that referenced
this pull request
Jun 20, 2016
ad0752e Stop trimming when mapTx is empty (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
ad0752e Stop trimming when mapTx is empty (Pieter Wuille)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
ad0752e Stop trimming when mapTx is empty (Pieter Wuille)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CTxMemPool::TrimToSize is called with a very low number (like somewhere in mempool_tests), it is possible that the memory usage never sinks below the specified number.
This is unlikely to be a problem right now, but will be with the introduction of CTxMemPool::vTxHashes in #8068.